Audit logs are not fully keyboard navigable

Open Beginner friendly
  • Is something wrong?
#6,530 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
66/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
angular, typescript
Domain
accessibility, frontend

Research direction

Start at the Audit Logs pages and locate the table row interaction used on both sitewide and item-level pages. Check how rows receive focus and handle keyboard events, then run the relevant UI tests if available. Done means rows can be reached by Tab, show a clear focus indicator, and open or close their details with Space.

Written by the indexing model from the issue text.

Description

accessibility affects: 10.x affects: main bug help wanted

Describe the bug

The tables on the Audit Logs pages, both sitewide and item-level, have some issues with keyboard navigation. The rows of the table are interactive elements, and so need to be able to gain focus and be opened via keyboard actions.

To Reproduce

  1. Go to an audit logs page, for example https://demo.dspace.org/auditlogs
  2. Observe the interactive elements of the table by clicking on a row to see details
  3. Start clicking "Tab" to navigate through the page; note that the ID links are the only elements that gain focus. It isn't possible to get to one of the table rows to open the collapse.
Image

Expected behavior

When a user is navigating via keyboard, the table rows themselves should be able to gain a visible focus. They should likely allow a space interaction to open/close the collapse so the user can see details.

Dominant language
TypeScript
Stars
180
Forks
577
Avg merge
2d 1h
Merged PRs (30d)
100

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DSpace/dspace-angular

All issues in DSpace/dspace-angular

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.