Facet headings have incorrect clickable area to expand/collapse
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- angular, typescript
- Domain
- accessibility, frontend
Research direction
The bug sits in the facet heading markup and styles: the .facet-filter container shows a pointer cursor, but only the button.filter-name inside it toggles the facet. Start by finding where .facet-filter and button.filter-name are defined in the Angular facet component and its stylesheet, then check whether the click handler belongs on the button or the container. Done means clicking anywhere on the heading expands or collapses the facet, and the cursor matches the clickable area in the browser.
Written by the indexing model from the issue text.
Description
Describe the bug
Hovering over a facet heading box turns the cursor to a pointer, indicating a clickable region to expand/collapse the facet. But unless you click in the middle part of the box where the text/button actually renders, clicking will have no effect.
To illustrate: the dashed blue region (.facet-filter) currently has cursor: pointer; but only clicks within the red dashed region (button.filter-name) will actually collapse/expand the filter.
This is an accessibility problem, and it appears to affect all currently-supported versions of DSpace (8.x, 9.x, 10.x).
To Reproduce
Steps to reproduce the behavior:
- Visit a page with facets
- Hover over a facet heading, observe pointer
- Click toward outer edge of that heading
- See that nothing happens
Expected behavior
Clicking on any part of the facet heading should expand/collapse the facet.
- Dominant language
- TypeScript
- Stars
- 180
- Forks
- 577
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 115
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DSpace/dspace-angular
-
bug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
DSpace/dspace-angular#6511 ·
Maintainers usually reply within 1 day
-
Visual issues with qualdrop fieldsPossibly taken @DanGastardelli claimed this 5 days ago. Openaffects: 10.x affects: 9.x bug claimed: Acervos Digitais component: submission Difficulty: Low ux
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
DSpace/dspace-angular#6412 · 3 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
Author browse links on item page open in a new tab, unlike other browse linksPossibly taken @jesielviana claimed this 26 days ago. Openaffects: main bug component: Item low priority
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
DSpace/dspace-angular#6268 · 4 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
Mathjax single dollar sign delimiter configuration causes unintentional math rendering in abstractsOpenbug needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
DSpace/dspace-angular#6263 ·
Maintainers usually reply within 1 day
-
UI spacing regression on ds-generic-item-page-field (extra spaces around metadata values) in v10.xOpenaffects: 10.x affects: main bug component: Item ux
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
DSpace/dspace-angular#6254 · 1 comment ·
Maintainers usually reply within 1 day
All issues in DSpace/dspace-angular
Similar issues
-
[fullsend] E2E: scorecard — filecheck GitLab entity metrics unavailable due to initialDelay timingOpene2e-failure ready-to-code
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
redhat-developer/rhdh-plugin-export-overlays#4698 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
devswha/herdr-web-ui#2884 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
b:minor bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
software-mansion/argent#1771 ·
Maintainers usually reply within 1 day
-
Resources: New palettes of XiamenPossibly taken @rmt-svc claimed this today. Openresources
Difficulty 1/5 1-3 hours Newbie friendliness 74/100
railmapgen/rmg-palette#2491 ·
Maintainers usually reply within 4 days