We changed email regex patterns in one place to Angular built-in, but kept our own regex in another place. We may change both?

Open
#6,006 3 comments 1 reaction 1 assignee View on GitHub

Maintainers usually reply within 1 day

@guillermo-escire is already working on this.

Since Aug 13, 2026.

Assessment

This issue has not been assessed yet.

Description

claimed: eScire code task improvement

Describe the bug

We changed email regex patterns in one place to Angular built-in, but kept our own regex in another place. We may change both?
Previously changed email regex pattern:
https://github.com/DSpace/dspace-angular/pull/4999

Stil remaining DSpace’s own email regex pattern for the feedback form:
https://github.com/DSpace/dspace-angular/blob/444edd4981726bdd872ffacd9302cd824cbd929f/src/app/info/feedback/feedback-form/feedback-form.component.ts#L58

Expected behavior

We should validate all email address input fields identically and get rid of custom regex code.

Related work

https://github.com/DSpace/dspace-angular/pull/4999

Dominant language
TypeScript
Stars
180
Forks
577
Avg merge
2d 1h
Merged PRs (30d)
100

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DSpace/dspace-angular

All issues in DSpace/dspace-angular

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.