UI Caching Issue When Admin User Is Attempting To Move Item Between Collections

Open
  • Is something wrong?
#5,734 2 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
angular, typescript
Domain
frontend

Research direction

The bug is in the Angular UI of dspace-angular: after moving an item to another collection, the breadcrumb still shows the old owning collection until a page refresh. Start by finding the move-item page component and the NgRx store actions/reducers that refresh the cached item after a move. Done means the breadcrumb updates right after a successful move, confirmed by a spec covering that component.

Written by the indexing model from the issue text.

Description

affects: 9.x bug component: Item help wanted low priority

Describe the bug

When an admin user is trying to move an item from it's owning collection to a new collection the DSpace UI caching does not reflect the change without first refreshing the page. This leads endusers to assume that the item has not been moved to the new collection. It seems that when you move an item for the first time the change is not reflected.  A refresh displays the move has been made and further moves are reflected instantly. But the initial move does not.

To Reproduce

The user wants to move an item from one owning collection to another.
They are logged in and have admin permissions.
They navigate to the item page click the edit button and navigate to the 'Status' tab.
They click the 'Move this Item to a different Collection' button and are navigated to the 'Move Item: xxx' page.
They search/select a collection from the dropdown.
They check the 'Inherent policies' (where applicable) checkbox and click the 'Save' button.
They are displayed a success pop-up.

Expected behavior

The owing collection display in the breadcrumbs should be updated to reflect the move

Note

It was also highlighted that when selecting a Collection from the dropdown it was not clear that a selection had been made. Clicking on the dropdown does not instantiate a visual change, i.e. it is not clear to the enduser the selection has been made. There is a bit of highlighting which is displayed as either a bit of greying of the background of the selected element or as a thick outline on the selected element but the enduser did not recognise this as confirmation that their selection had been made.

Dominant language
TypeScript
Stars
180
Forks
577
Avg merge
2d 1h
Merged PRs (30d)
100

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DSpace/dspace-angular

All issues in DSpace/dspace-angular

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.