Remove the SIP to PV conversion
Maintainers usually reply within 1 day
@lbaumo is already working on this.
Since Feb 15, 2023.
Assessment
This issue has not been assessed yet.
Description
In the split_exp package we are converting the WCS PV keywords to SIP to read the WCS with astropy, and this is not necessary. At the moment astropy cannot read the current WCS because the TYPE of the WCS is set to RA--TAN instead of RA--TPV. This was not a problem in the past because astropy allows inconsistency between the TYPE and the provided keywords, but now it is more strict about it. Also the TAN and TPV conventions are the same. I would propose to remove the conversion in the pipeline and instead update the TYPE in the header to avoid the dependence to an external package and changing the original WCS.
- Dominant language
- Python
- Stars
- 18
- Forks
- 14
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 18
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CosmoStat/shapepipe
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Maintainers usually reply within 1 day
All issues in CosmoStat/shapepipe
Similar issues
-
docs pydanty:is-working
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
pydantic/pydantic-ai#8863 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
run-llama/llama_index#23278 ·
Maintainers usually reply within 2 days
-
documentation from-review-extraction github-actions priority: low severity:nit
Difficulty 1/5 Under an hour Newbie friendliness 92/100
LearningCircuit/local-deep-research#6946 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
oracle/langchain-oracle#323 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
tenstorrent/tt-metal#58057 · 1 comment ·
Maintainers usually reply within 1 day