Pin PSFEx's compiled-in SAMPLE_* candidate cuts explicitly in default.psfex
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 85/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- tooling
Research direction
Edit workflow/config/cfis/default.psfex and compare its SAMPLE_* settings with the compiled-in values from psfex -dd in the develop-runtime image. Record the listed candidate-cut defaults explicitly, retain SAMPLE_AUTOSELECT N, and remove the [HARDCODED] marker so the decision record can assert the configuration.
Written by the indexing model from the issue text.
Description
workflow/config/cfis/default.psfex sets SAMPLE_AUTOSELECT N and leaves every other SAMPLE_* key to PSFEx's compiled-in defaults — a second PSF-star selection no config records. From psfex -dd in the develop-runtime image (PSFEx 3.21.1): SAMPLE_MINSN 20, SAMPLE_MAXELLIP 0.3, SAMPLE_FWHMRANGE 2.0,10.0, SAMPLE_VARIABILITY 0.2, SAMPLE_FLAGMASK 0x00fe, SAMPLE_WFLAGMASK 0x0000, SAMPLE_IMAFLAGMASK 0x0, BADPIXEL_FILTER N. Which of these still act with autoselect off is not stated in the PSFEx docs (MAXELLIP alone is a real cut on the PSF-star sample). Write them into default.psfex explicitly so the decision record (#875, star_selection_psf.psfex_candidate_vetting) can assert them and a PSFEx upgrade cannot move them silently; the [HARDCODED] marker then goes.
- Dominant language
- Python
- Stars
- 18
- Forks
- 14
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 18
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CosmoStat/shapepipe
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
Maintainers usually reply within 1 day
All issues in CosmoStat/shapepipe
Similar issues
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
openvinotoolkit/openvino_notebooks#3665 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
docs
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
benchmark-gap
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day