mask_query.flag_positions treats every negative map value as off-coverage
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
Research direction
Start at shapepipe.utilities.mask_query.flag_positions and inspect how the map exposes its off-coverage sentinel. Verify the logic distinguishes that sentinel from other negative values, then run the relevant existing tests and add coverage for a legitimate negative map value; done means only off-coverage is treated as clean.
Written by the indexing model from the issue text.
Description
shapepipe.utilities.mask_query.flag_positions zeroes every negative integer map value, not only healsparse's off-coverage sentinel, so a map that legitimately carried negative values would read as clean. Correct today (UNIONS maps carry non-negative bits), but the contract off-coverage-is-clean holds only by that accident; compare against the map's sentinel explicitly. Found while writing that contract (#875).
- Dominant language
- Python
- Stars
- 18
- Forks
- 14
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 18
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CosmoStat/shapepipe
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
Maintainers usually reply within 1 day
All issues in CosmoStat/shapepipe
Similar issues
-
pydanty:is-working
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
pydantic/pydantic-ai#8843 ·
Maintainers usually reply within 1 day
-
breaking change enhancement server
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
sktime/sktime#11310 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day