ux(dateien): add an empty-state message to FilesView
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 91/100
Research direction
Read src/LageBuch.App.Shared/Views/FilesView.axaml and compare it with src/LageBuch.App.Shared/Views/LinksView.axaml around line 52. Add the German empty-state message using TextMutedBrush and bind the list border visibility to the file count; keep the change scoped to FilesView. Verify with make test PROJECT=tests/LageBuch.Acceptance.Tests FILTER=Name~Files and make run.
Written by the indexing model from the issue text.
Description
The Dateien tab shows an empty bordered table when an incident has no
attachments. There is no sentence telling the user that this is normal and what
to do about it.
LinksView already solves exactly this, and it is three lines. From
src/LageBuch.App.Shared/Views/LinksView.axaml line 52:
<TextBlock DockPanel.Dock="Top" x:Name="EmptyText" Text="Keine Links hinterlegt."
Foreground="{StaticResource TextMutedBrush}"
IsVisible="{Binding !Links.Count}" />
with the counterpart IsVisible="{Binding Links.Count}" on the list Border so
the two never show at once.
What to do
Apply the same pattern to src/LageBuch.App.Shared/Views/FilesView.axaml:
- add an
EmptyTextblock bound to the inverse of the file collection's count - bind the existing list
Bordervisibility to the count so the empty frame
does not sit behind the message - use
TextMutedBrush, matching the Links tab
Keep the message German, calm and short. Something in the spirit of
Keine Dateien angehängt. fits the house style; the existing add button right
below already tells the user how to add one.
Scope this PR to FilesView only. Several other tabs have the same gap and will
get their own issues.
Verify
make test PROJECT=tests/LageBuch.Acceptance.Tests FILTER=Name~Files
make run
Difficulty: easy.
New here?
Comment to claim this issue and it is yours. If no pull request appears within
seven days it goes back in the pool, no hard feelings.
Before you open the PR, please skim CONTRIBUTING.md:
commits need DCO sign-off (git commit -s) and a Conventional Commit subject.
Changes under src/ additionally need an entry under ## [Unreleased] in
CHANGELOG.md — CI fails the PR otherwise.
Questions are welcome right here or in
Discussions.
- Dominant language
- C#
- Stars
- 1
- Forks
- 3
- Avg merge
- 4h 34m
- Merged PRs (30d)
- 182
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CodeForFire/lagebuch
-
bug ux
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
CodeForFire/lagebuch#714 ·
Maintainers usually reply within 1 day
-
bug ux
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
CodeForFire/lagebuch#713 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
CodeForFire/lagebuch#405 ·
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
CodeForFire/lagebuch#349 ·
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
CodeForFire/lagebuch#348 ·
Maintainers usually reply within 1 day
All issues in CodeForFire/lagebuch
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
bug priority: P2
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
IridiumIO/CompactGUI#699 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day