Metric chart with aggFn increase and a multi-column group-by fails: toString() gets several arguments
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- clickhouse, typescript
- Domain
- backend, observability
Research direction
Start in packages/common-utils/src/core/renderChartConfig.ts, especially the increase group-by filtering path described in the issue, and compare it with the series-limit CTE’s handling of comma-separated group-by columns. Check nearby tests for increase with grouped metrics and add coverage for two columns supplied as a comma-separated string. Done means the query accepts the multi-column group-by and returns one series per column pair.
Written by the indexing model from the issue text.
Description
What happened?
A metric chart on a Sum metric with aggFn: increase and a group-by of two or more columns, given as a comma-separated string, fails with:
An incorrect number of arguments was specified for function 'toString'. Expected 1 argument, got 2 arguments: In scope SELECT tuple(Attributes['destination_service_name'], Attributes['response_code']) AS group, sum(Rate) AS bucket_value FROM Bucketed WHERE (Attributes['destination_service_name'], ((Attributes['response_code']) IS NOT NULL) AND (toString(Attributes['destination_service_name'], Attributes['response_code']) != '')) GROUP BY group, __hdx_time_bucket2.
Expected: one series per (destination_service_name, response_code) pair, the same as with a single group-by column.
What we checked on the same metric and time range:
increasewith one group-by column works.sumwith the same two-column group-by works.increasewith two columns fails both with Map expressions (Attributes['a'], Attributes['b']) and with plain MATERIALIZED columns (`col_a`, `col_b`).
As far as we can tell, the cause is in the top-N ranking added for increase + group-by (packages/common-utils/src/core/renderChartConfig.ts at 7752c88):
renderSelectListreturns a string group-by as a singleChSql(if (typeof selectList === 'string') return chSql\${{ UNSAFE_RAW_SQL: selectList }}``): https://github.com/hyperdxio/hyperdx/blob/7752c880e0f2d96be8926af71beebdf0b1e7d4b6/packages/common-utils/src/core/renderChartConfig.ts#L733-L741- The
increasepath then treats that single fragment as one column.groupByEmptyFilterwraps the wholea, bin(… IS NOT NULL AND toString(…) != ''): https://github.com/hyperdxio/hyperdx/blob/7752c880e0f2d96be8926af71beebdf0b1e7d4b6/packages/common-utils/src/core/renderChartConfig.ts#L2341-L2362 - The series-limit CTE handles the same case by splitting a string group-by with
splitAndTrimWithBracketfirst: https://github.com/hyperdxio/hyperdx/blob/7752c880e0f2d96be8926af71beebdf0b1e7d4b6/packages/common-utils/src/core/renderChartConfig.ts#L1605-L1614
Splitting the string group-by the same way before building groupByEmptyFilter should fix it. The tuple(${groupBySql}) parts already work with the comma-separated form.
Steps to reproduce
Reproduces on play.hyperdx.io? Didn't try. We hit it through the MCP tools on our own deployment.
- Use a Metric source whose sum table has a counter with two attributes, for example Istio's
istio_requests_total(destination_service_name,response_code). - Call the MCP tool
clickstack_tablewith:select: [{"aggFn": "increase", "metricType": "sum", "metricName": "istio_requests_total"}]groupBy: "Attributes['destination_service_name'], Attributes['response_code']"
- It fails with the error above.
- Change
aggFntosum, or drop the second group-by column. It works.
We haven't checked the UI chart editor. It renders through the same renderChartConfig, so we expect a two-column group-by on an increase chart to fail the same way there.
How are you running HyperDX?
Helm (ClickStack chart 2.1.0) with the hyperdx:2-nightly image, which is 2.42.0 plus the Node bump from #3456. Our own ClickHouse 26.2.5.45.
Where does it show up?
The API: the MCP tool clickstack_table.
Debug info
N/A. We saw this through the API's MCP tools, not the UI.
Logs
The error is quoted above.
Written with help from an AI assistant (Claude Code). The behaviour and the error come from our own deployment.
- Dominant language
- TypeScript
- Stars
- 10.1k
- Forks
- 527
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 186
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ClickHouse/ClickStack
-
external
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ClickHouse/ClickStack#3761 ·
Maintainers usually reply within 1 day
-
Slack notifications for inline alerts fail when the chart-explorer link passes Slack's 3000-character block limitPossibly taken @Tyagiquamar claimed this 27 days ago. Openalerting bug external
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
ClickHouse/ClickStack#3452 ·
Maintainers usually reply within 1 day
-
check-alerts worker: 13 error spans (mongodb.create, NamespaceExists) every minute because mongoose autoCreate is still onMay be free again A pull request for this issue was closed without being merged. Openbug external Needs Feedback
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ClickHouse/ClickStack#3308 · 1 comment ·
Maintainers usually reply within 1 day
-
count_distinct aggFn on metric tiles ignores valueExpression, always counts distinct metric ValuesPossibly taken @Harshul1484 claimed this 54 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ClickHouse/ClickStack#2311 ·
Maintainers usually reply within 1 day
-
enhancement Needs Feedback
Difficulty 5/5 Over a week Newbie friendliness 25/100
ClickHouse/ClickStack#3687 ·
Maintainers usually reply within 1 day
All issues in ClickHouse/ClickStack
Similar issues
-
Add: GTrekkerOpencheck:passed streams:add
Difficulty 1/5 Under an hour Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
area: ui Bug Payload OSS
Difficulty 1/5 Under an hour Newbie friendliness 88/100
payloadcms/payload#19839 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
fix(auth): add the email OTP verification step to Pollar loginPossibly taken @akansnoro claimed this today. OpenStellar Wave
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
safetrustcr/dApp-SafeTrust#584 · 10 comments ·
Maintainers usually reply within 1 day
-
The manager preset saves launch definitions without the required file and digest pairPossibly taken A pull request linked to this issue is open or already merged. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day