Start: server function ids naming Object.prototype members (constructor, __proto__) hit a TypeError in the resolver

Open Beginner friendly
#8,974 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
85/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
node.js, typescript, vite
Domain
backend, tooling

Research direction

Start in packages/start-plugin-core/src/start-compiler/server-fn-resolver-module.ts at the manifest lookup inside getServerFnById; the issue gives the exact fix (Object.hasOwn). Then open packages/start-plugin-core/src/vite/start-compiler-plugin/plugin.ts and apply the same own-property check to both serverFnsById[fnId] guards. Run the start-plugin-core resolver/compiler tests; done means ids like constructor, __proto__ and toString throw the same 'Server function info not found for' error as an unknown id, in both the generated resolver and the dev server.

Written by the indexing model from the issue text.

Description

Which project does this relate to?

Start

Describe the bug

A server function request whose id names an Object.prototype member (constructor, __proto__, toString, hasOwnProperty, …) fails with a TypeError inside the resolver instead of the "not found" error an unknown id gets, so an app that answers unknown ids with a 404 (by catching Server function info not found for) still answers these with a 500.

The generated resolver looks the id up with a plain property read (packages/start-plugin-core/src/start-compiler/server-fn-resolver-module.ts):

const manifest = { /* ids */ }

export async function getServerFnById(id, access) {
  const serverFnInfo = manifest[id]          // manifest['constructor'] === Object
  if (!serverFnInfo) {
    throw new Error('Server function info not found for ' + id)
  }
  // with includeClientReferencedCheck false (the Vite plugin when ssr is the provider)
  const fnModule = serverFnInfo.module ?? (await serverFnInfo.importer())
  // TypeError: serverFnInfo.importer is not a function

manifest is an object literal, so inherited members pass the !serverFnInfo check and the resolver throws a TypeError instead of its own "not found" error. Any client can send such an id, so stray or probing traffic turns into 500s and server errors.

The dev server has the same lookup in packages/start-plugin-core/src/vite/start-compiler-plugin/plugin.ts (if (fnId && serverFnsById[fnId]) and if (serverFnsById[fnId])), so a prototype id passes the "Invalid server function ID" guard there and fails later.

Complete minimal reproducer

No separate repository: it reproduces in any Start app built with the Vite plugin and default settings, with the request below. We confirmed it by importing the module generateServerFnResolverModule emits with includeClientReferencedCheck: false and calling getServerFnById('constructor'), which throws TypeError: serverFnInfo.importer is not a function where an unknown id throws Server function info not found for ….

Steps to Reproduce the Bug
  1. Build and start any Start app (vite build, then run the server output).
  2. curl -i -X POST -H 'Sec-Fetch-Site: same-origin' http://localhost:3000/_serverFn/constructor
  3. Compare with curl -i -X POST -H 'Sec-Fetch-Site: same-origin' http://localhost:3000/_serverFn/no-such-id.

The server log for step 2 shows TypeError: serverFnInfo.importer is not a function; step 3 shows Server function info not found for no-such-id. __proto__ and toString behave like step 2, for GET and POST. In dev, the prototype id passes the Invalid server function ID guard and fails later with a different error.

Expected behavior

Every id the manifest does not own resolves like an unknown id. An own-property check fixes all four lookups; we run this as a local patch:

-  const serverFnInfo = manifest[id]
+  const serverFnInfo = Object.hasOwn(manifest, id) ? manifest[id] : undefined
-          if (fnId && serverFnsById[fnId]) {
+          if (fnId && Object.hasOwn(serverFnsById, fnId)) {

(and the same for the second serverFnsById[fnId] check in the dev-server plugin). The rsbuild path uses the same generator, so it is covered by the first change. A Object.create(null) manifest would work too.

Platform
  • @tanstack/start-plugin-core 1.172.0 (also present on main today)
  • @tanstack/react-start 1.169.7
  • Node 26.13.0, macOS and Linux
Additional context

With includeClientReferencedCheck: true the request fails earlier as "Server function not accessible from client", so only builds where that check is off (the Vite plugin when the ssr environment is the provider) reach the TypeError; the dev-server guard is affected either way.

Dominant language
TypeScript
Stars
15.3k
Forks
1.9k
Avg merge
1d 5h
Merged PRs (30d)
46

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TanStack/router

All issues in TanStack/router

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.