Can't change populated values back to null

Open
  • Is something wrong?
#337 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
frontend

Research direction

Start by locating the map editor’s event property editing code for JSON fields and boolean checkboxes, then trace how edited values are saved. Check whether the editor exposes a way to clear a property back to null; done means both fields can be cleared and the change is covered by an appropriate test. The issue gives no file or test path, so first identify the relevant entry point.

Written by the indexing model from the issue text.

Description

Once a json field has a value, you cannot set it back to null in the map editor. For example, if you create a SHOW_CHOICE event step, all the fields are initially blank/null. Once you enter a value, save it, then close the event editor, it is no longer able to go back to null. You cannot delete this value because it map editor will re-populate it.
Image

In the screenshot above, if I want to set the forceWidth field to a null value again, I either need to make an entirely new SHOW_CHOICE event step or I need to remove it manually in json.

This also works for boolean checkbox properties. In the screenshot below, the top SET_CAMERA_POS is a freshly-created event step, thus all values are currently null. Once you touch the checkbox for the wait property, you can only set it to true or false. You can't get rid of it from the editor now.

Image

This is all just a minor annoyance, not anything critical. I can always still manually work around this.

Dominant language
TypeScript
Stars
59
Forks
19
Avg merge
32m
Merged PRs (30d)
2

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from CCDirectLink/crosscode-map-editor

All issues in CCDirectLink/crosscode-map-editor

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.