wrong save file type

Open
  • Is something wrong?
#247 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
55/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
angular, html, typescript
Domain
frontend

Research direction

Inspect webapp/src/app/components/load-map/load-map.component.html at the linked line and check how the save file type is specified. Reproduce the file picker behavior with .json files, then confirm it shows the expected files after the fix.

Written by the indexing model from the issue text.

Description

bug

from discord (EL#0503)

really minor bug that i discovered:

i think the save as file type is bugged because it's not showing json files when i think it's trying to look for files with a ..json extension rather than .json

i think it's supposed to just be accept="json" here: https://github.com/CCDirectLink/crosscode-map-editor/blob/701d1b557e75e5e67b29035afe9362aad29ed299/webapp/src/app/components/load-map/load-map.component.html#L25
image
image

more photos to show it's really looking for ..json
image
image

Dominant language
TypeScript
Stars
59
Forks
19
Avg merge
32m
Merged PRs (30d)
2

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from CCDirectLink/crosscode-map-editor

All issues in CCDirectLink/crosscode-map-editor

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.