Bug: Editor can't render ScalableProp with undefined size

Open
  • Is something wrong?
#243 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
tooling

Research direction

Start by tracing how the editor loads and renders scalable props, using waterfallLong in heat-dng/f2/room-cold and sandLine in heat-dng/g/room-09 as examples. Compare those vanilla props with the JSON workaround that supplies a size. Done means both kinds of vanilla prop appear in the editor and can be interacted with.

Written by the indexing model from the issue text.

Description

Some vanilla maps use scalable props with undefined size. Inside heat-dng/f2/room-cold, there are scalable props called waterfallLong from the heat-dng sheet that do not have a defined size. The map editor doesn't render these at all, thus there is no way to interact with them without blindly doing it in the json.

image
image

Another example of this are the sandLine props from the heat-dng sheet. These can be found in heat-dng/g/room-09.

A workaround is to manually define a prop in the JSON which includes a value for size. These will work and show up in the editor, but vanilla props will not.
image
image

Dominant language
TypeScript
Stars
59
Forks
19
Avg merge
32m
Merged PRs (30d)
2

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from CCDirectLink/crosscode-map-editor

All issues in CCDirectLink/crosscode-map-editor

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.