commerce_cart binding anchors the whole app root when the cart drawer is a sibling of main, overlapping other bindings

Open
#6,302 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
53/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
php, wordpress
Domain
backend, testing

Research direction

Start by tracing Static_Site_Importer_Runtime_Entity_Binding_Validation::preflight_runtime_entity_binding_anchors() and the binding logic that resolves the commerce_cart region. Use the reduced fixture with #cart-drawer as a regression case and check the existing cases related to #4131, #6173, and #6202. Done means the cart binding selects its own region or is declined with a diagnostic, and the regression confirms binding ranges do not overlap.

Written by the indexing model from the issue text.

Description

Summary

A single-page storefront whose cart drawer sits as a direct child of the app root fails materialization:

static_site_importer_runtime_binding_claim_conflict: Provider entity bindings claim overlapping canonical source-page ranges.

The commerce_cart binding resolves to the entire app root group: <div id="app">, about 85 KB, which is the whole page body. It does not resolve to the cart drawer. That range overlaps another provider binding on the same page (bytes 32234–62258), so Static_Site_Importer_Runtime_Entity_Binding_Validation::preflight_runtime_entity_binding_anchors() correctly rejects the import.

This is the same family as #4131 (a header cart link becoming a page-wide region) and #6173 (bindings moving onto a neighbouring block). It still reproduces on SSI 1.34.102, which vendors php-transformer v0.48.13 and includes the #6202 fix.

Evidence

Instrumented SSI validation on the failing binding:

  • role: commerce_cart, occurrence: 1, position: {block_index: 0, offset: 0, length: 84700}
  • projected_anchor.source_block_length: 78136, source_position.block_index: 0
  • search_block_markup starts with <!-- wp:group {"anchor":"app", …} --><div id="app" …>, which is the outermost page group.

Source shape, reduced:

<body>
  <div id="app">
    <div class="announcement">…</div>
    <header>… <button aria-label="Open bag">Bag (0)</button> …</header>
    <main>… product cards with "Add to bag" buttons … <form id="newsletter">…</form></main>
    <footer>…</footer>
    <div class="cart-drawer" id="cart-drawer" aria-label="Shopping bag">
      <div class="drawer-head"><h3>Your bag <span id="drawer-count">(0)</span></h3><button id="close-cart" aria-label="Close bag">×</button></div>
      <div id="cart-items"></div>
      <div class="drawer-foot"><p>Subtotal <strong id="subtotal">$0.00</strong></p><button class="primary-btn" id="checkout">Continue to checkout →</button></div>
    </div>
    <div class="scrim" id="scrim"></div>
  </div>
</body>

Expected

  • The cart binding anchors the cart region's own block (#cart-drawer) or its opener.
  • If no block narrower than a page-wide ancestor carries the cart identity, the binding is declined with a diagnostic and the page still imports.
  • A binding range never spans the entire document root while other bindings sit inside it.
  • Add a regression test on the reduced fixture above, asserting that the cart binding's markup contains id="cart-drawer" and that no two binding ranges overlap.

AI assistance: diagnosed by Claude (Claude Code), with local instrumented reproduction, under operator direction.

Dominant language
PHP
Stars
28
Forks
5
Avg merge
2h 59m
Merged PRs (30d)
942

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Automattic/blocks-engine

All issues in Automattic/blocks-engine

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.