commerce_cart binding anchors the whole app root when the cart drawer is a sibling of main, overlapping other bindings

Aperta
#6,302 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
53/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
php, wordpress
Ambito
backend, testing

Direzione di ricerca

Start by tracing Static_Site_Importer_Runtime_Entity_Binding_Validation::preflight_runtime_entity_binding_anchors() and the binding logic that resolves the commerce_cart region. Use the reduced fixture with #cart-drawer as a regression case and check the existing cases related to #4131, #6173, and #6202. Done means the cart binding selects its own region or is declined with a diagnostic, and the regression confirms binding ranges do not overlap.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

A single-page storefront whose cart drawer sits as a direct child of the app root fails materialization:

static_site_importer_runtime_binding_claim_conflict: Provider entity bindings claim overlapping canonical source-page ranges.

The commerce_cart binding resolves to the entire app root group: <div id="app">, about 85 KB, which is the whole page body. It does not resolve to the cart drawer. That range overlaps another provider binding on the same page (bytes 32234–62258), so Static_Site_Importer_Runtime_Entity_Binding_Validation::preflight_runtime_entity_binding_anchors() correctly rejects the import.

This is the same family as #4131 (a header cart link becoming a page-wide region) and #6173 (bindings moving onto a neighbouring block). It still reproduces on SSI 1.34.102, which vendors php-transformer v0.48.13 and includes the #6202 fix.

Evidence

Instrumented SSI validation on the failing binding:

  • role: commerce_cart, occurrence: 1, position: {block_index: 0, offset: 0, length: 84700}
  • projected_anchor.source_block_length: 78136, source_position.block_index: 0
  • search_block_markup starts with <!-- wp:group {"anchor":"app", …} --><div id="app" …>, which is the outermost page group.

Source shape, reduced:

<body>
  <div id="app">
    <div class="announcement">…</div>
    <header>… <button aria-label="Open bag">Bag (0)</button> …</header>
    <main>… product cards with "Add to bag" buttons … <form id="newsletter">…</form></main>
    <footer>…</footer>
    <div class="cart-drawer" id="cart-drawer" aria-label="Shopping bag">
      <div class="drawer-head"><h3>Your bag <span id="drawer-count">(0)</span></h3><button id="close-cart" aria-label="Close bag">×</button></div>
      <div id="cart-items"></div>
      <div class="drawer-foot"><p>Subtotal <strong id="subtotal">$0.00</strong></p><button class="primary-btn" id="checkout">Continue to checkout →</button></div>
    </div>
    <div class="scrim" id="scrim"></div>
  </div>
</body>

Expected

  • The cart binding anchors the cart region's own block (#cart-drawer) or its opener.
  • If no block narrower than a page-wide ancestor carries the cart identity, the binding is declined with a diagnostic and the page still imports.
  • A binding range never spans the entire document root while other bindings sit inside it.
  • Add a regression test on the reduced fixture above, asserting that the cart binding's markup contains id="cart-drawer" and that no two binding ranges overlap.

AI assistance: diagnosed by Claude (Claude Code), with local instrumented reproduction, under operator direction.

Lingua principale
PHP
Stelle
28
Fork
5
Merge medio
2h 59m
PR unite (30g)
942

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Automattic/blocks-engine

Tutte le issue di Automattic/blocks-engine

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.