Visual iframe drops source size attributes when its rules only position it
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
Research direction
Start by reading VisualIframeBlockGenerator::sourceOwnsIframeGeometry() and find the tests for visual iframe generation. Check how a positioned iframe with source width and height attributes is handled, then run the relevant tests. Done means the saved iframe retains both size attributes when its author rule only positions it.
Written by the indexing model from the issue text.
Description
Problem
A visual iframe whose only author rule positions it, e.g. .frame{position:absolute}, loses its source width/height attributes and renders at the browser default of 300×150.
VisualIframeBlockGenerator::sourceOwnsIframeGeometry() counts position as source-owned geometry, and source-owned geometry drops the size attributes. Positioning does not size the frame, though. In the source, the attributes are what size it.
Repro
<style>.pinned{position:absolute}</style>
<main><div class="slot"><iframe class="pinned" src="https://forms.example.test/share" title="Signup" width="398" height="497"></iframe></div></main>
Expected: the saved iframe keeps width="398" height="497". Actual: neither attribute is emitted.
Real-world case
On a Wix page (/pipinbloom), a MailerLite signup embed (.xxJnkq{position:absolute}, width="398" height="497") renders as a 300×150 window that cuts off everything below the heading.
- Dominant language
- PHP
- Stars
- 25
- Forks
- 3
- Avg merge
- 2h 23m
- Merged PRs (30d)
- 942
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Automattic/blocks-engine
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/blocks-engine#5003 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Automattic/blocks-engine#4943 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Automattic/blocks-engine#4942 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Automattic/blocks-engine#775 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Automattic/blocks-engine#5013 ·
Maintainers usually reply within 1 day
All issues in Automattic/blocks-engine
Similar issues
-
from-cloud mythic tracked
Difficulty 1/5 Under an hour Newbie friendliness 86/100
MythicalLTD/FeatherPanel#459 · 1 comment ·
Maintainers usually reply within 1 day
-
[Bug]: PostgreSQL backend: Queue.remove() / Job.remove() never emit the QueueEvents "removed" eventPossibly taken @1AbdullahButt claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
taskforcesh/bullmq#5085 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
shukiv/jabali-panel#2423 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
-
customer-reported enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
MagnaCapax/PMSS#1252 ·
Maintainers usually reply within 3 days