Post chrome: a post missing an optional section stays unfactored
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
Start from the existing post-chrome-* tests to see how layout groups and templates are built, then find where single-post groups are skipped and where post_chrome_order_retained findings are emitted (make findings reflect only the final grouping outcome). Add a unit test under php-transformer/tests/unit/ reproducing four posts where only d lacks the author box, asserting d's post_content holds only its body and that no stray findings appear. Done means that test passes and the existing post-chrome-* suite stays green.
Written by the indexing model from the issue text.
Description
Problem
A post missing an optional section that its peers have ends up alone in its layout group, and single-post groups are skipped. Examples are the author profile box, which Blogger omits for some authors, or a related section that is hidden or empty. The post keeps its full chrome in post_content even though it is the same layout minus one section.
Reproduction
Four posts with the same chrome; a, b and c have an author box after the body, d doesn't.
| Case | Result |
|---|---|
| author box missing on one post | a/b/c 209 B; d 3073 B, unfactored (3 findings) |
| hidden empty related section on d, related lists disjoint | all 209 B (already handled by #6111) |
Once related-route dedupe is fixed (separate issue), a hidden related section on d reduces to this same case.
Expected
A post that differs from a factored group only by absent optional sections joins the closest group's template. Because those sections are part of the template, they need to render nothing for that post (for example, the section is outside post-content and its blocks are post-bound or conditional). If they can't render empty, the post stays separate but keeps only its body in its own template. It should never keep the whole page in post_content.
Also: a grouping attempt that gets discarded still records post_chrome_order_retained findings. Only emit findings for the final outcome.
Acceptance
A unit test under php-transformer/tests/unit/ where d's post_content holds only its body and there are no stray findings. Existing post-chrome-* tests pass.
AI disclosure: filed by Claude (Anthropic) running in the Pi coding agent, from instrumented reproduction on a real Blogger import.
- Dominant language
- PHP
- Stars
- 28
- Forks
- 5
- Avg merge
- 2h 59m
- Merged PRs (30d)
- 942
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Automattic/blocks-engine
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Automattic/blocks-engine#6318 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Automattic/blocks-engine#4943 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Automattic/blocks-engine#4942 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Automattic/blocks-engine#4921 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Automattic/blocks-engine#775 ·
Maintainers usually reply within 1 day
All issues in Automattic/blocks-engine
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
TYPO3-Solr/ext-solr#4850 ·
Maintainers usually reply within 2 days
-
[Sync EN] stream: document the errors of the stream_context_*() and stream filter functions (#6091)Opensync-en
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
[Sync EN] stream: document the errors of the stream_context_*() and stream filter functions (#6091)Opensync-en
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
Перевод устарел
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
glpi-project/glpi#26353 · 2 comments ·
Maintainers usually reply within 1 day