Post chrome: a post missing an optional section stays unfactored

Open
#6,155 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
php, wordpress
Domain
content, tooling

Research direction

Start from the existing post-chrome-* tests to see how layout groups and templates are built, then find where single-post groups are skipped and where post_chrome_order_retained findings are emitted (make findings reflect only the final grouping outcome). Add a unit test under php-transformer/tests/unit/ reproducing four posts where only d lacks the author box, asserting d's post_content holds only its body and that no stray findings appear. Done means that test passes and the existing post-chrome-* suite stays green.

Written by the indexing model from the issue text.

Description

Problem

A post missing an optional section that its peers have ends up alone in its layout group, and single-post groups are skipped. Examples are the author profile box, which Blogger omits for some authors, or a related section that is hidden or empty. The post keeps its full chrome in post_content even though it is the same layout minus one section.

Reproduction

Four posts with the same chrome; a, b and c have an author box after the body, d doesn't.

Case Result
author box missing on one post a/b/c 209 B; d 3073 B, unfactored (3 findings)
hidden empty related section on d, related lists disjoint all 209 B (already handled by #6111)

Once related-route dedupe is fixed (separate issue), a hidden related section on d reduces to this same case.

Expected

A post that differs from a factored group only by absent optional sections joins the closest group's template. Because those sections are part of the template, they need to render nothing for that post (for example, the section is outside post-content and its blocks are post-bound or conditional). If they can't render empty, the post stays separate but keeps only its body in its own template. It should never keep the whole page in post_content.

Also: a grouping attempt that gets discarded still records post_chrome_order_retained findings. Only emit findings for the final outcome.

Acceptance

A unit test under php-transformer/tests/unit/ where d's post_content holds only its body and there are no stray findings. Existing post-chrome-* tests pass.


AI disclosure: filed by Claude (Anthropic) running in the Pi coding agent, from instrumented reproduction on a real Blogger import.

Dominant language
PHP
Stars
28
Forks
5
Avg merge
2h 59m
Merged PRs (30d)
942

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Automattic/blocks-engine

All issues in Automattic/blocks-engine

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.