Post chrome: a post missing an optional section stays unfactored

Abierto
#6,155 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
php, wordpress
Área
content, tooling

Línea de trabajo

Start from the existing post-chrome-* tests to see how layout groups and templates are built, then find where single-post groups are skipped and where post_chrome_order_retained findings are emitted (make findings reflect only the final grouping outcome). Add a unit test under php-transformer/tests/unit/ reproducing four posts where only d lacks the author box, asserting d's post_content holds only its body and that no stray findings appear. Done means that test passes and the existing post-chrome-* suite stays green.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem

A post missing an optional section that its peers have ends up alone in its layout group, and single-post groups are skipped. Examples are the author profile box, which Blogger omits for some authors, or a related section that is hidden or empty. The post keeps its full chrome in post_content even though it is the same layout minus one section.

Reproduction

Four posts with the same chrome; a, b and c have an author box after the body, d doesn't.

Case Result
author box missing on one post a/b/c 209 B; d 3073 B, unfactored (3 findings)
hidden empty related section on d, related lists disjoint all 209 B (already handled by #6111)

Once related-route dedupe is fixed (separate issue), a hidden related section on d reduces to this same case.

Expected

A post that differs from a factored group only by absent optional sections joins the closest group's template. Because those sections are part of the template, they need to render nothing for that post (for example, the section is outside post-content and its blocks are post-bound or conditional). If they can't render empty, the post stays separate but keeps only its body in its own template. It should never keep the whole page in post_content.

Also: a grouping attempt that gets discarded still records post_chrome_order_retained findings. Only emit findings for the final outcome.

Acceptance

A unit test under php-transformer/tests/unit/ where d's post_content holds only its body and there are no stray findings. Existing post-chrome-* tests pass.


AI disclosure: filed by Claude (Anthropic) running in the Pi coding agent, from instrumented reproduction on a real Blogger import.

Lenguaje dominante
PHP
Estrellas
28
Forks
5
Merge medio
2 h 59 min
PR fusionados (30 d)
942

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Automattic/blocks-engine

Todos los issues de Automattic/blocks-engine

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.