Perf: coordinate-only projections skip pushdown, so every data variable is still loaded
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 72/100
- Issue 类型
- 重构
- 描述清晰度
- 描述清楚
- 活跃度
- 冷清
调研方向
决定是否下推的谓词位于 src/lib.rs 中的 PrunableStreamingTable::scan()(约第 607-614 行)。阅读 read_xarray_table 中对应的工厂分支,以及 iter_record_batches 中没有数据变量的分支,然后检查复现脚本的调用次数。当 SELECT lat, lon 向工厂传入非 None 的投影、不读取任何数据变量分块,并返回与未投影扫描一致的批次,且有新测试覆盖时,即为完成。
由索引模型根据 Issue 内容生成。
描述
Problem
PrunableStreamingTable::scan() only pushes the projection down to the Python partition factory when the projection contains at least one data variable. A projection made purely of dimension coordinates falls through to the non-pushdown branch, the factory is called with None, and every data variable in every scanned partition is loaded from storage before ProjectionExec throws it away.
src/lib.rs (main @ 5d7633e, lines 607 to 614):
// - projection contains only dimension columns (ds.to_dataframe()
// needs at least one data variable; dimensions are always loaded)
let push_projection = match projection {
Some(indices) if !indices.is_empty() => indices
.iter()
.any(|&i| !self.dimension_columns.contains(self.schema.field(i).name())),
_ => false,
};
The reason given in that comment no longer holds. The factory built by read_xarray_table already handles a coordinate-only projection explicitly:
if data_vars_needed:
ds_block = ds[data_vars_needed].isel(block)
else:
# Only dimension coords requested - drop all data vars to avoid
# loading them unnecessarily (e.g. for queries like SELECT lat, lon).
ds_block = ds.drop_vars(list(ds.data_vars)).isel(block)
and iter_record_batches has a matching if ds.data_vars: ... else: ... branch that takes its shape from ds.sizes when the Dataset has no data variables. So the Python side is ready for this case; only the Rust predicate keeps it unreachable.
Reproducer
Counts real data-variable chunk reads with a dask.array.map_blocks counter, and records the projection the factory receives.
import dask, dask.array as da, numpy as np, pandas as pd, xarray as xr
from datafusion import SessionContext
from xarray_sql import read_xarray_table
dask.config.set(scheduler="synchronous")
loads = {"n": 0}
def block(block_info=None):
loads["n"] += 1 # one call == one data-var chunk read
return np.zeros(block_info[None]["chunk-shape"], dtype="float32")
ds = xr.Dataset(
{
name: (("time", "lat", "lon"),
da.map_blocks(block, dtype="float32",
chunks=((10,) * 4, (20,), (30,))))
for name in ("air", "hum")
},
coords={"time": pd.date_range("2000-01-01", periods=40),
"lat": np.linspace(-90, 90, 20),
"lon": np.linspace(0, 359, 30)},
)
seen = []
ctx = SessionContext()
ctx.register_table("t", read_xarray_table(
ds, {"time": 10}, _iteration_callback=lambda blk, proj: seen.append(proj)))
for sql in ("SELECT COUNT(*) c FROM t",
"SELECT lat, air FROM t",
"SELECT DISTINCT lat FROM t",
"SELECT lat, lon FROM t"):
loads["n"], seen[:] = 0, []
ctx.sql(sql).to_pandas()
proj = str(seen[0]) if seen else "(no scan)"
print(f"{sql:28} projection={proj:22} chunks_loaded={loads['n']}")
Output on main (4 partitions, 2 data variables):
SELECT COUNT(*) c FROM t projection=(no scan) chunks_loaded=0
SELECT lat, air FROM t projection=['lat', 'air'] chunks_loaded=4
SELECT DISTINCT lat FROM t projection=None chunks_loaded=8
SELECT lat, lon FROM t projection=None chunks_loaded=8
SELECT lat, air is correct: pushdown happens and only air is read, 4 chunks. The two coordinate-only queries read 8 chunks, both data variables across all four partitions, for an answer that needs zero data-variable bytes.
Impact
Any query answered entirely from the coordinate axes still pays for the full data payload:
SELECT DISTINCT time FROM dsorSELECT DISTINCT level FROM dsto discover what an axis containsSELECT lat, lon FROM ds WHERE ...to fetch a grid outlineCOUNT(DISTINCT lat)- any front end populating filter widgets from the dimension coordinates
On a local NetCDF this is a wasted copy. On a remote Zarr store it is a chunk fetch per data variable per partition. The waste also scales with the number of data variables in the table, which the same-dimensions grouping in from_dataset makes the common case.
Proposed fix
Push the projection whenever it is Some and non-empty, dropping the "contains at least one data variable" condition, and update the comment. The non-pushdown branch stays for None and Some([]).
I checked the Python half directly rather than assuming it: feeding iter_record_batches a block with drop_vars(list(ds.data_vars)) and a coords-only pa.schema returns the right row count and columns, so the projected path looks ready for this. I have not built the Rust change yet, so the predicate edit still needs compiling and testing.
Worth adding a test that asserts the factory receives the coordinate-only projection and that the resulting batches match the unprojected scan.
Parent: #126
- 主要语言
- Python
- 星标
- 142
- 派生
- 19
- 平均合并
- 1 天 9 小时
- 30 天内合并 PR
- 10
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
xqlsystems/xarray-sql 的其他 Issue
-
documentation
难度 1/5 1-3 小时 新手友好度 85/100
xqlsystems/xarray-sql#268 ·
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 64/100
xqlsystems/xarray-sql#267 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 74/100
xqlsystems/xarray-sql#243 ·
维护者通常 1 天内回复
-
publish.yml: the TestPyPI verification step is unreachable (and installs the wrong package name)未关闭
难度 2/5 1-3 小时 新手友好度 62/100
xqlsystems/xarray-sql#242 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 72/100
xqlsystems/xarray-sql#231 ·
维护者通常 1 天内回复
查看 xqlsystems/xarray-sql 的全部 Issue
相似的 Issue
-
bug Size: XS
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
oposs/repo-infra#93 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
-
难度 2/5 1-3 小时 新手友好度 69/100
Graphify-Labs/graphify#4546 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 65/100
521xueweihan/HelloGitHub#4025 ·