Rework package management to allow composition of dependencies
@smortex 已经在做这个了。
开始于 2025年1月10日。
评估
这个 Issue 还没有评估数据。
描述
This issue has the purpose of tracking progress for improving the way the puppet-python module manage packages.
Issues we want to solve
In these example, we assume a control-repo with a profile::python class that wraps the puppet-python module with site-specific config:
class profile::python {
class { 'python':
ensure => present,
# ...
}
}
System packages with dependencies on python-foo
The syslog-ng-mod-python package depend on python-venv. When this package is added to the catalog, puppet will install syslog-ng-mod-python, which will install python-venv as a dependency. On next run, python-venv is removed (because the python class default to ensure this package is absent) and syslog-ng-mod-python which depend on it is also removed.
To workaround this issue, we can skip management of the python-venv in the python module with:
class profile::python {
class { 'python':
# ...
manage_venv_package => false, # python-venv is a dependency of syslog-ng-mod-python
}
}
If another node need to have the venv package installed, we have a few solutions:
- Add a parameter to the
profile::pythonand use Hiera to set it to a custom value on the nodes that must have different behavior; - Duplicate and adjust the
profile::pythonclass (e.g.profile::python_with_venv) and include one or the other of these two conflicting profiles, leading to some duplication; - Manage the
python-venvpackage in the profile that need it, duplicating what the puppet-python module is supposed to manage.
None of these solutions is great.
Puppet modules needing a specific component
The puppet-puppetboard module rely on the puppet-python module. When installing from a venv, it include this code in the catalog:
class { 'python':
version => $python_version,
dev => 'present',
venv => 'present',
}
This clash with the above profile::python. To cope with this, the module provide a manage_virtualenv parameter to skips this fragment and allow the user to handle this themself, with the same solutions and same drawbacks as seen in the previous example.
How puppetlabs-apache handle a similar issue
Apache has a lot of different modules, but each one is managed in a different class allowing to do some composition of the dependencies from another puppet module, e.g.:
class taiga::vhost {
include apache
include apache::mod::passenger
# ...
}
For the end-user include taiga::vhost will do the right thing, and if they want to customize the apache::mod::passenger parameters, they can do this in their code:
class profile::taiga {
class { 'apache::mod::passenger':
# ... this would be in a passenger specific profile
}
class { 'taiga::vhost':
# ...
}
}
Roadmap
After this long context, I propose to rework the module package management to match what is done by puppetlabs-apache, make it easier to manage dependencies in consumer modules and avoid conflicts.
This is a three step process:
- Allow to opt-out of management of
python-dev(enhancement) #669 [Released in v7.1.0]; - Move components installation code in dedicated classes (enhancement) #670;
- Change defaults for packages which are ensured absent by default: switch them to installed but do not manage them by default (backwards-incompatible).
- 主要语言
- Ruby
- 星标
- 196
- 派生
- 371
- 平均合并
- 5 小时 54 分钟
- 30 天内合并 PR
- 5
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
voxpupuli/puppet-python 的其他 Issue
-
难度 3/5 1-2 天 新手友好度 67/100
voxpupuli/puppet-python#759 ·
-
bug
难度 3/5 1-2 天 新手友好度 45/100
voxpupuli/puppet-python#743 · 1 条评论 ·
-
enhancement
难度 3/5 1-2 天 新手友好度 35/100
voxpupuli/puppet-python#721 · 1 个 reaction ·
-
难度 3/5 1-2 天 新手友好度 35/100
voxpupuli/puppet-python#711 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 52/100
voxpupuli/puppet-python#673 · 1 条评论 ·
查看 voxpupuli/puppet-python 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 82/100
matteocrippa/awesome-swift#2028 ·
维护者通常 3 天内回复
-
难度 2/5 1-3 小时 新手友好度 75/100
fractaledmind/litestream-ruby#89 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 1/5 1-3 小时 新手友好度 78/100
resque/resque-scheduler#848 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 78/100
voxpupuli/puppet-patroni#126 ·
-
难度 2/5 1-3 小时 新手友好度 68/100
voxpupuli/puppet-elasticsearch#1290 ·