cache.output: opt-in exact restore, so a hit removes files the cached run did not write
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- rust
- 领域
- build-system
调研方向
Read crates/vt/src/session/cache/archive.rs around lines 56–65 and crates/vt/src/session/cache/mod.rs around lines 589–600 to follow cache restoration; then inspect collect_glob_paths in crates/vt/src/session/execute/cache_update.rs. The issue proposes an opt-in replace flag for object-form output entries that removes matching files missing from the archive before unpacking. Done means replacement entries restore exact matching outputs while entries without the flag and { auto: true } keep current behavior; the payload names no tests.
由索引模型根据 Issue 内容生成。
描述
Written by an AI agent (Claude) on behalf of @jasonkuhrt.
Problem
A cache hit unpacks the output archive over the workspace and deletes nothing (archive.rs L56-65, called from restore). For a task whose run replaces a folder, a hit therefore does not leave what a run leaves: a file in that folder that the cached run never wrote survives the hit.
Reproduction on vite-plus 1.4.0:
// vite.config.ts
import { defineConfig } from 'vite-plus';
export default defineConfig({
run: {
tasks: {
generate: {
command: 'node generate.mjs',
cache: {
input: ['generate.mjs', 'names.txt'],
output: ['generated/**'],
},
},
},
},
});
// generate.mjs: replaces generated/ whole, one file per name in names.txt
import { mkdirSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
rmSync('generated', { recursive: true, force: true });
mkdirSync('generated');
for (const name of readFileSync('names.txt', 'utf8').split(/\s+/).filter(Boolean)) {
writeFileSync(`generated/${name}.ts`, `export const ${name} = 1;\n`);
}
$ echo 'a b' > names.txt
$ vp run generate
$ node generate.mjs
$ ls generated
a.ts b.ts
$ echo 'export const c = 1;' > generated/c.ts # a file an earlier run left
$ vp run generate
$ node generate.mjs ◉ cache hit, replaying
$ ls generated
a.ts b.ts c.ts # c.ts survives the hit
$ vp run --no-cache generate
$ node generate.mjs ⊘ cache disabled
$ ls generated
a.ts b.ts # a run removes it
In practice c.ts comes from the checkout's own earlier run: a commit removes or renames something the task generates a file for, the checkout pulls it, and the remote cache already holds the run for the new commit. We hit this with a Prisma client generator: a removed scalar's file outlived the restore, and type checking failed with TS2307 on its now-missing import.
Why the runner can't infer it
The disk plus the archive can't tell a leftover from a file the task means to keep. If the command writes one file per name and deletes nothing, a run also leaves c.ts, and today's merge matches that run. Only the config author knows that a run replaces the folder.
Proposal
An opt-in on the object form of an output entry:
cache: {
output: [{ pattern: 'generated/**', replace: true }],
},
On a hit, before unpacking, the restore matches the entry's pattern against the disk with the same collect_glob_paths that builds the archive, negative globs included, and deletes the matches the archive lacks. Entries without replace, and { auto: true }, keep today's behavior.
- With #901 (leave outputs that already match untouched), a
replacehit becomes an exact sync: matching files untouched, changed files rewritten, leftovers removed. - Docs: a
replaceentry owns every file its pattern matches. Two tasks whosereplacepatterns overlap would delete each other's files on a hit. - The name
replaceis a suggestion.
The workaround available today, an uncached task that deletes the outputs before the cached one runs, makes every output file disappear for as long as the restore takes, so another task of the same run or an editor reading them in that window sees them missing.
- 主要语言
- Rust
- 星标
- 480
- 派生
- 50
- 平均合并
- 1 天 5 小时
- 30 天内合并 PR
- 63
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
voidzero-dev/vite-task 的其他 Issue
-
难度 5/5 一周以上 新手友好度 35/100
voidzero-dev/vite-task#921 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 56/100
voidzero-dev/vite-task#910 · 1 条评论 ·
维护者通常 1 天内回复
-
Automatic output tracking misses files a task renames into place, so a cache hit restores nothing未关闭
难度 4/5 3-5 天 新手友好度 48/100
voidzero-dev/vite-task#908 ·
维护者通常 1 天内回复
-
Export OpenTelemetry client spans for the native remote cache可能已有人在做 @jasonkuhrt 于 1 天前认领。 未关闭
难度 4/5 3-5 天 新手友好度 25/100
voidzero-dev/vite-task#906 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 56/100
voidzero-dev/vite-task#905 ·
维护者通常 1 天内回复
查看 voidzero-dev/vite-task 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 62/100
calcit-lang/caps#16 ·
-
难度 2/5 1-3 小时 新手友好度 85/100
penso/herdr-gpui#934 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
Y-ASLant/ElegantClipboard#178 ·
-
难度 2/5 1-3 小时 新手友好度 82/100
linxiv-dev/linXiv#384 · 1 条评论 ·
维护者通常 1 天内回复
-
priority middle
难度 2/5 1-3 小时 新手友好度 70/100
KATO-Hiro/AtCoderClans#12945 ·
维护者通常 1 天内回复