cache.output: opt-in exact restore, so a hit removes files the cached run did not write
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 55/100
- Issue 類型
- 功能
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- rust
- 領域
- build-system
研究方向
Read crates/vt/src/session/cache/archive.rs around lines 56–65 and crates/vt/src/session/cache/mod.rs around lines 589–600 to follow cache restoration; then inspect collect_glob_paths in crates/vt/src/session/execute/cache_update.rs. The issue proposes an opt-in replace flag for object-form output entries that removes matching files missing from the archive before unpacking. Done means replacement entries restore exact matching outputs while entries without the flag and { auto: true } keep current behavior; the payload names no tests.
由索引模型根據 Issue 內容生成。
描述
Written by an AI agent (Claude) on behalf of @jasonkuhrt.
Problem
A cache hit unpacks the output archive over the workspace and deletes nothing (archive.rs L56-65, called from restore). For a task whose run replaces a folder, a hit therefore does not leave what a run leaves: a file in that folder that the cached run never wrote survives the hit.
Reproduction on vite-plus 1.4.0:
// vite.config.ts
import { defineConfig } from 'vite-plus';
export default defineConfig({
run: {
tasks: {
generate: {
command: 'node generate.mjs',
cache: {
input: ['generate.mjs', 'names.txt'],
output: ['generated/**'],
},
},
},
},
});
// generate.mjs: replaces generated/ whole, one file per name in names.txt
import { mkdirSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
rmSync('generated', { recursive: true, force: true });
mkdirSync('generated');
for (const name of readFileSync('names.txt', 'utf8').split(/\s+/).filter(Boolean)) {
writeFileSync(`generated/${name}.ts`, `export const ${name} = 1;\n`);
}
$ echo 'a b' > names.txt
$ vp run generate
$ node generate.mjs
$ ls generated
a.ts b.ts
$ echo 'export const c = 1;' > generated/c.ts # a file an earlier run left
$ vp run generate
$ node generate.mjs ◉ cache hit, replaying
$ ls generated
a.ts b.ts c.ts # c.ts survives the hit
$ vp run --no-cache generate
$ node generate.mjs ⊘ cache disabled
$ ls generated
a.ts b.ts # a run removes it
In practice c.ts comes from the checkout's own earlier run: a commit removes or renames something the task generates a file for, the checkout pulls it, and the remote cache already holds the run for the new commit. We hit this with a Prisma client generator: a removed scalar's file outlived the restore, and type checking failed with TS2307 on its now-missing import.
Why the runner can't infer it
The disk plus the archive can't tell a leftover from a file the task means to keep. If the command writes one file per name and deletes nothing, a run also leaves c.ts, and today's merge matches that run. Only the config author knows that a run replaces the folder.
Proposal
An opt-in on the object form of an output entry:
cache: {
output: [{ pattern: 'generated/**', replace: true }],
},
On a hit, before unpacking, the restore matches the entry's pattern against the disk with the same collect_glob_paths that builds the archive, negative globs included, and deletes the matches the archive lacks. Entries without replace, and { auto: true }, keep today's behavior.
- With #901 (leave outputs that already match untouched), a
replacehit becomes an exact sync: matching files untouched, changed files rewritten, leftovers removed. - Docs: a
replaceentry owns every file its pattern matches. Two tasks whosereplacepatterns overlap would delete each other's files on a hit. - The name
replaceis a suggestion.
The workaround available today, an uncached task that deletes the outputs before the cached one runs, makes every output file disappear for as long as the restore takes, so another task of the same run or an editor reading them in that window sees them missing.
- 主要語言
- Rust
- 星號
- 480
- 分支
- 50
- 平均合併
- 1 天 5 小時
- 30 天內合併 PR
- 63
環境準備
在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
voidzero-dev/vite-task 的其他 Issue
-
難度 5/5 一週以上 新手友好度 35/100
voidzero-dev/vite-task#921 ·
維護者通常 1 天內回覆
-
難度 4/5 3-5 天 新手友好度 56/100
voidzero-dev/vite-task#910 · 1 則留言 ·
維護者通常 1 天內回覆
-
Automatic output tracking misses files a task renames into place, so a cache hit restores nothing未關閉
難度 4/5 3-5 天 新手友好度 48/100
voidzero-dev/vite-task#908 ·
維護者通常 1 天內回覆
-
Export OpenTelemetry client spans for the native remote cache可能已有人在做 @jasonkuhrt 今天認領。 未關閉
難度 4/5 3-5 天 新手友好度 25/100
voidzero-dev/vite-task#906 ·
維護者通常 1 天內回覆
-
難度 4/5 3-5 天 新手友好度 56/100
voidzero-dev/vite-task#905 ·
維護者通常 1 天內回覆
查看 voidzero-dev/vite-task 的全部 Issue
相似的 Issue
-
priority middle
難度 1/5 1 小時以內 新手友好度 62/100
KATO-Hiro/AtCoderClans#12940 ·
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 83/100
維護者通常 1 天內回覆
-
o8 next debug build aborts on Glass to Dark appearance switch (nil identifier messaged before check)未關閉bug
難度 2/5 1-3 小時 新手友好度 78/100
hurttlocker/o8#5112 ·
-
難度 2/5 1-3 小時 新手友好度 79/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆