dts: Ivy members are matched to classes by name only (wrong component metadata, renamed `X$1` left plain)

未关闭
  • 哪里不对？
#691 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
43/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
javascript, typescript
领域
build-system, tooling

调研方向

Start in vite-plugin/index.ts, in generateBundle and the byClassName lookup described in the issue. Trace how declaration classes are collected and matched to bundled .d.ts files, especially when names collide or gain $N suffixes. Reproduce the two cases with rolldown-plugin-dts or tsdown; done means each declaration receives only its own component metadata, and a plain class is not given another module's metadata.

由索引模型根据 Issue 内容生成。

描述

Found while reviewing #683. Older than it (the asset path has always done this), but #683 makes it reachable for rolldown-plugin-dts / tsdown, where bundling and renames happen.

The dts plugin (vite-plugin/index.ts, generateBundle, byClassName) keys the collected declarations by class name only (last one wins), and injects them into every .d.ts in the bundle by the name it finds there. The source module is never compared.

case 1: same name, two modules, one bundled .d.ts
  src/b/card.component.ts  class Card  (b-card, input title)
  src/c/card.component.ts  class Card  (c-card, input size)
  second.ts: export { Card as BCard } from './b/…'; export { Card as CCard } from './c/…'

  second.d.ts (rolldown-plugin-dts renames the clash):
    declare class Card   { title…; static ɵcmp: ComponentDeclaration<Card, "c-card", …{size}…> }  <- wrong component
    declare class Card$1 { size… }                                                             <- no members → NG2012
  (which module wins changes between runs: wrong metadata in 8 of 12 identical builds)

case 2: same name in another entry
  angular.ts → @Component({selector:'lib-button'}) class Button
  utils.ts   → plain class Button { label = 'x' }

  utils.d.ts: import * as i0 from "@angular/core"; class Button { static ɵfac…; static ɵcmp<Button, "lib-button"…> }

Possible direction: match by source module (the chunk's module ids, the rolldown-plugin-dts $N renames), or at least skip and warn on names that come from more than one module rather than write another class's metadata.

主要语言
Rust
星标
245
派生
26
平均合并
1 天 42 分钟
30 天内合并 PR
83

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

voidzero-dev/oxc-angular-compiler 的其他 Issue

查看 voidzero-dev/oxc-angular-compiler 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。