Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

Decide: two `@Component` on one class — ngtsc compiles the first with no error; OXC's HMR text scan pairs the second

已关闭
  • 哪里不对？
#521 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
angular, rust, typescript
领域
build-system, tooling

调研方向

Start with the two-decorator reproduction and compare ngtsc and OXC output and runtime behavior. Read crates/oxc_angular_compiler/src/component/transform.rs, napi/angular-compiler/vite-plugin/utils/decorator-fields.ts, and napi/angular-compiler/vite-plugin/index.ts; done requires an agreed option and matching compiler metadata and HMR behavior.

由索引模型根据 Issue 内容生成。

描述

question 
import {Component} from '@angular/core';
@Component({selector: 'a-cmp', template: 'first'})
@Component({selector: 'b-cmp', template: 'second'})
export class C {}

ngtsc 22.1.7 gives no diagnostic. It compiles the first @Component and leaves the second as a runtime decorator. At runtime that second decorator replaces ɵcmp with a JIT getter, so the module crashes on load without @angular/compiler. Same with OXC's output. So the input is broken under both compilers, and there is no ngtsc error for OXC to copy.

OXC still differs from ngtsc in two small ways. Opening this to decide whether either is worth fixing.

Compile output

OXC (#504 tip and main, same output):

@Component({selector: 'b-cmp', template: 'second'})
export class C {
static ɵcmp = /*@__PURE__*/ i0.ɵɵdefineComponent({type:C,selectors:[["a-cmp"]], ... i0.ɵɵtext(0,"first") ...});
}
... i0.ɵsetClassMetadata(C,[{type:Component,args:[{selector:"a-cmp",template:"first"}]}],null,null)

ngtsc 22.1.7:

let C = class C {
    static ɵcmp = /*@__PURE__*/ i0.ɵɵdefineComponent({ type: C, selectors: [["a-cmp"]], ... i0.ɵɵtext(0, "first") ... });
};
C = __decorate([
    Component({ selector: 'b-cmp', template: 'second' })
], C);
... i0.ɵsetClassMetadata(C, [{
        type: Component,
        args: [{ selector: 'a-cmp', template: 'first' }]
    }, {
        type: Component,
        args: [{ selector: 'b-cmp', template: 'second' }]
    }], null, null)

Both compile the first decorator and keep the second. Difference 1: ngtsc's setClassMetadata lists both decorators, OXC's lists only the compiled one.

Runtime (node, @angular/core 22.1.7, no @angular/compiler), both outputs:

Error: The component 'C' needs to be compiled using the JIT compiler, but '@angular/compiler' is not available.

HMR (Vite plugin)

Rust reports componentDecorators = {"c.ts@C": "Component"}, and templateUpdates["c.ts@C"] is the template of the first decorator (ɵɵtext(0,"first")).

stripComponentMetadata empties the template: / styles: of the decorator locateComponentDecorators pairs with C. Pass 2 of that scan looks for class X only between one decorator's ) and the next decorator's @, so the first @Component pairs with no class and the second one gets C. Difference 2: the plugin empties the decorator the compiler did not take:

pairs: [["C","({selector: 'b-cmp', template: 'second'})"]]
edit first  (compiled)     -> stripped forms differ => full reload
edit second (not compiled) -> stripped forms equal  => HMR event, but the update holds the first template, so nothing changes

(Checked by running the real decorator-fields.ts functions and a copy of stripComponentMetadata with oxnode. Same pairing on main, where the scan only looks for the literal @Component(.)

Where

  • crates/oxc_angular_compiler/src/component/transform.rs: find_component_decorator takes the first match (same as ngtsc); component_decorators reports only its callee text, not its position.
  • napi/angular-compiler/vite-plugin/utils/decorator-fields.ts: locateComponentDecorators, pass 2 (bounded class-name scan).
  • napi/angular-compiler/vite-plugin/index.ts: stripComponentMetadata keys the decorators by class name, so two same-spelled decorators on one class can't be told apart.

On main?

Yes (both differences). componentDecorators itself is only on the #504 stack (d1fa6c4).

Options

  1. Leave as is: the input already crashes at runtime with ngtsc too.
  2. Report the compiled decorator's span (not only its spelling) in componentDecorators, so the plugin empties exactly that one.
  3. List every class decorator in setClassMetadata, like ngtsc.
  4. Add a warning for a second Angular class decorator of the same kind (ngtsc has none, so this would go beyond ngtsc).
主要语言
Rust
星标
232
派生
21
平均合并
1 天 23 小时
30 天内合并 PR
53

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

voidzero-dev/oxc-angular-compiler 的其他 Issue

查看 voidzero-dev/oxc-angular-compiler 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。