sanity_check_attributes bodies are mostly empty across visuals
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 25/100
- Issue 类型
- 缺陷
- 描述清晰度
- 需要澄清
- 活跃度
- 冷清
- 技术栈
- python
调研方向
Start by auditing the listed sanity_check_attributes and sanity_check_attributes_buffer methods across gsp/visuals, gsp/geometry, gsp/materials, and gsp/core, beginning with the pass implementations and shallow Buffer checks. Use the existing rgba8 enforcement in gsp/materials/mesh_basic_material.py and the related #20 Bug 6 context as reference. Done means each class has defined BufferType, count, and applicable shape or range validation that fails clearly at construction or the buffer boundary.
由索引模型根据 Issue 内容生成。
描述
Short tracking issue — most sanity_check_attributes / sanity_check_attributes_buffer static methods across the visuals/geometry/material/texture classes are either pass or limited to isinstance(x, Buffer) checks. As a result, malformed input (wrong dtype, wrong shape, mismatched counts) crashes deep in numpy at render time instead of failing clearly at construction or at the buffer boundary.
Audit (as of mesh_ng):
gsp/visuals/mesh.py—sanity_check_attributesispass;_bufferform only delegates.gsp/visuals/markers.py— bothpass.gsp/visuals/paths.py— bothpass.gsp/geometry/mesh_geometry.py— bothpass.gsp/visuals/pixels.py,points.py,segments.py,texts.py—_bufferonly has shallowisinstance(_, Buffer)checks; no shape/dtype/count validation.gsp/visuals/image.py,gsp/core/texture.py— partial type checks only.gsp/materials/mesh_basic_material.py—_buffernow enforces rgba8 on face/edge colors (#20 Bug 5); the non-buffer form is stillpass.
What good would look like (per class):
- Buffer
BufferTypematches the expected encoding (e.g. positions →vec3, indices →uint32, colors →rgba8). - Buffer count consistency between related attributes (e.g. material color count ∈ {1, vertex_count, face_count}).
- Optionally O(N) range checks (e.g.
max(indices) < vertex_count) at the buffer boundary.
Related: this is the larger Bug 6 from #20, broadened beyond Mesh.
This is just a placeholder to come back to — no fix scoped yet.
- 主要语言
- Python
- 星标
- 2
- 派生
- 0
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
vispy/GSP_API 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 64/100
-
难度 3/5 1-2 天 新手友好度 35/100
-
难度 5/5 一周以上 新手友好度 25/100
-
难度 3/5 1-2 天 新手友好度 65/100
-
难度 2/5 1-3 小时 新手友好度 45/100
相似的 Issue
-
agent-ready documentation needs-triage
难度 1/5 1-3 小时 新手友好度 88/100
-
documentation
难度 1/5 1 小时以内 新手友好度 91/100
-
workflow-status page template still says reusable workflows are "triggered only by workflow_call:" 未关闭
难度 1/5 1 小时以内 新手友好度 92/100
-
instance instance add
难度 1/5 1 小时以内 新手友好度 72/100
searxng/searx-instances#939 · 1 条评论 ·
-
area-deployment area-integrations triage:bot-seen
难度 2/5 半天 新手友好度 86/100