Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

Work Intent: Stop the disks query from spinning up array disks (#2018)

未关闭
  • 哪里不对？
#2,105 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
64/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
linux, typescript
领域
api, operating-systems, performance

调研方向

Start in disks.service.ts at getDisks(), then read getPhysicalDisks(), parseDisk(), and blockDevices() to understand the current disk shape and partition handling. Run the existing disk-service tests before adding coverage for lsblk mapping, smartctl standby status, device filtering, and ensuring diskLayout() is no longer called. Done means disk-list queries avoid waking standby disks while preserving the expected disk fields and status behavior.

由索引模型根据 Issue 内容生成。

描述

Overview

Fix #2018. Any query that goes through DisksService.getDisks() wakes every spun-down array disk: disks, disk(id), assignableDisks and the onboarding Internal Boot step (getAssignableDisks() / getInternalBootDevices()). Even { disks { id } } is enough. Anything that polls the disk list keeps large drives from staying in standby.

The cause is the same one #2090 / #2091 found for temperatures: getDisks() builds its list from diskLayout() in systeminformation, which on Linux runs smartctl -a -j and smartctl -H on every disk without -n standby.

I've been running the approach below as a runtime patch on my own server (Unraid 7.3, mixed array with 16 and 18 TB drives) for a few months. With the disks spun down, { disks { id } } spins up every large drive on stock, and none with the patch. The query also goes from several seconds to under 500 ms.

Technical Approach

  • Replace diskLayout() in getDisks() with a listing from lsblk -d -b -J -O, which only reads kernel metadata. Ideally this builds on getPhysicalDisks() from #2091 once it lands, adding the columns getDisks() needs (vendor, firmware revision, rotational) so there is a single place that lists disks.
  • Map each device to the shape diskLayout() returns today, so parseDisk() stays as it is: device, name (model), vendor, serialNum, firmwareRevision, interfaceType (from tran), size in bytes, and type as HD / SSD / NVMe (from rota and tran, same values diskLayout() returns). lsblk reports vendor: "ATA" for SATA drives, so in that case the vendor is derived from the model string.
  • Get smartStatus from smartctl -n standby -H -j <device>. Exit code 2 means the disk is in standby and was not queried, which maps to UNKNOWN.
  • Keep blockDevices() for partitions.
  • Tests: unit tests for the lsblk mapping (size in bytes, drive type, vendor fallback, filtering out loop/ram devices) and for the smartctl status mapping, plus a test that getDisks() no longer calls diskLayout().

Out of scope: the geometry fields on Disk (bytesPerSector, totalSectors, etc.) are non-nullable but diskLayout() already returns null for them on Linux, so selecting them errors today. This change would leave them as they are; happy to look at that separately.

Scope

  • API
  • Plugin
  • Web UI
  • Build/Deploy Process
  • Documentation

Timeline & Impact

  • Estimated time needed: a few days, since the logic already runs as a patch and mostly needs porting and tests. I'd start after #2091 is merged to avoid conflicts in disks.service.ts.
  • Potential impacts: smartStatus becomes UNKNOWN for disks in standby instead of waking them to read it. No schema changes.

Pre-submission Checklist

  • I have searched for similar work/issues
  • I understand this needs approval before starting
  • I am willing to make adjustments based on feedback
主要语言
TypeScript
星标
113
派生
23
平均合并
1 天 21 小时
30 天内合并 PR
12

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

unraid/api 的其他 Issue

查看 unraid/api 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。