Batch-scoped DLQ reconciler fails requests that another live batch owns
维护者通常 2 天内回复
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- go
调研方向
Read dlq/request.go for the existing owningBatch guard, then trace failBatch and its batch.Contains fan-out. Add coverage for a request owned by another non-terminal batch and for the reconciled batch's own members; done means only requests not owned by another live batch are terminated.
由索引模型根据 Issue 内容生成。
描述
Problem
The batch-scoped DLQ reconciler fails requests that another live batch owns. That batch may go on to merge the change, which leaves the request reported error for a change that lands.
How it is reached
A lost ack on the batch topic leaves two batch attempts for one request. If the redundant attempt's dependency-analysis message exhausts its retries (for example, a storage error while resolving dependencies), it dead-letters while still in creating. failBatch then moves it to failed and fans out over batch.Contains, terminating a request that reads batched and belongs to the first, healthy batch. TerminateRequest declines only when the request is already terminal, and batched is not terminal.
The guard to mirror
owningBatch in dlq/request.go already answers "which batch owns this request" for the request-scoped reconciler. The batch-scoped fan-out needs the inverse: skip a request when some other non-terminal batch owns it. The guard must exclude the batch being reconciled, or the batch counts as its own members' owner and the fan-out never happens.
Found in review of #590. As of 6c050082 the fan-out in failBatch has no ownership guard.
- 主要语言
- Go
- 星标
- 247
- 派生
- 16
- 平均合并
- 2 天 1 小时
- 30 天内合并 PR
- 125
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
uber/submitqueue 的其他 Issue
-
[Bug] Land returns codes.Unknown instead of InvalidArgument for an unrecognized strategy可能已有人在做 @DivyanshGarg380 于 14 天前认领。 未关闭bug
难度 1/5 1 小时以内 新手友好度 22/100
uber/submitqueue#996 ·
维护者通常 2 天内回复
-
Cancel misses a batch mid-promotion, letting a cancelled request reach speculation可能重新可做 @burgulvedant 于 14 天前认领，目前没有进行中的 PR。 未关闭bug
难度 4/5 3-5 天 新手友好度 45/100
uber/submitqueue#825 · 1 条评论 ·
维护者通常 2 天内回复
-
bug
难度 4/5 3-5 天 新手友好度 52/100
uber/submitqueue#824 · 2 条评论 ·
维护者通常 2 天内回复
-
bug
难度 4/5 3-5 天 新手友好度 55/100
uber/submitqueue#820 ·
维护者通常 2 天内回复
-
bug
难度 5/5 一周以上 新手友好度 35/100
uber/submitqueue#819 · 1 条评论 ·
维护者通常 2 天内回复
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 72/100
kubescape/node-agent#1099 ·
维护者通常 1 天内回复
-
import-export
难度 2/5 1-3 小时 新手友好度 72/100
genealogix/glx#1498 ·
维护者通常 2 天内回复
-
Bug pulumi/pulumi-terraform-bridge R2 S2
难度 1/5 1 小时以内 新手友好度 72/100
pulumi/pulumi-terraform-bridge#3713 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
ossf/pvtr-github-repo-scanner#539 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 75/100
goreleaser/goreleaser#7316 ·
维护者通常 1 天内回复