Batch-scoped DLQ reconciler fails requests that another live batch owns
維護者通常 2 天內回覆
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 55/100
- Issue 類型
- 缺陷
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- go
研究方向
Read dlq/request.go for the existing owningBatch guard, then trace failBatch and its batch.Contains fan-out. Add coverage for a request owned by another non-terminal batch and for the reconciled batch's own members; done means only requests not owned by another live batch are terminated.
由索引模型根據 Issue 內容生成。
描述
Problem
The batch-scoped DLQ reconciler fails requests that another live batch owns. That batch may go on to merge the change, which leaves the request reported error for a change that lands.
How it is reached
A lost ack on the batch topic leaves two batch attempts for one request. If the redundant attempt's dependency-analysis message exhausts its retries (for example, a storage error while resolving dependencies), it dead-letters while still in creating. failBatch then moves it to failed and fans out over batch.Contains, terminating a request that reads batched and belongs to the first, healthy batch. TerminateRequest declines only when the request is already terminal, and batched is not terminal.
The guard to mirror
owningBatch in dlq/request.go already answers "which batch owns this request" for the request-scoped reconciler. The batch-scoped fan-out needs the inverse: skip a request when some other non-terminal batch owns it. The guard must exclude the batch being reconciled, or the batch counts as its own members' owner and the fan-out never happens.
Found in review of #590. As of 6c050082 the fan-out in failBatch has no ownership guard.
- 主要語言
- Go
- 星號
- 252
- 分支
- 16
- 平均合併
- 2 天 1 小時
- 30 天內合併 PR
- 125
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
uber/submitqueue 的其他 Issue
-
[Bug] Land returns codes.Unknown instead of InvalidArgument for an unrecognized strategy可能已有人在做 @DivyanshGarg380 於 14 天前認領。 未關閉bug
難度 1/5 1 小時以內 新手友好度 22/100
uber/submitqueue#996 ·
維護者通常 2 天內回覆
-
Cancel misses a batch mid-promotion, letting a cancelled request reach speculation可能重新可做 @burgulvedant 於 14 天前認領，目前沒有進行中的 PR。 未關閉bug
難度 4/5 3-5 天 新手友好度 45/100
uber/submitqueue#825 · 1 則留言 ·
維護者通常 2 天內回覆
-
bug
難度 4/5 3-5 天 新手友好度 52/100
uber/submitqueue#824 · 2 則留言 ·
維護者通常 2 天內回覆
-
bug
難度 4/5 3-5 天 新手友好度 55/100
uber/submitqueue#820 ·
維護者通常 2 天內回覆
-
bug
難度 5/5 一週以上 新手友好度 35/100
uber/submitqueue#819 · 1 則留言 ·
維護者通常 2 天內回覆
相似的 Issue
-
ManageSieve proxy: a backend's NO/BYE greeting is skipped as a capability line and reported as EOF未關閉bug
難度 2/5 1-3 小時 新手友好度 72/100
維護者通常 1 天內回覆
-
Mend: dependency security vulnerability
難度 2/5 1-3 小時 新手友好度 62/100
ManageIQ/manageiq-pods#1476 ·
維護者通常 1 天內回覆
-
mcp: typed tool handlers lose wrapped JSON-RPC errors可能重新可做 關聯的 PR 已關閉且未合併。 未關閉
難度 2/5 1-3 小時 新手友好度 85/100
modelcontextprotocol/go-sdk#1529 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 1/5 1 小時以內 新手友好度 72/100
kubescape/node-agent#1099 ·
維護者通常 1 天內回覆
-
import-export
難度 2/5 1-3 小時 新手友好度 72/100
genealogix/glx#1498 ·
維護者通常 2 天內回覆