[Feature] Remove unused discovery message definitions
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 35/100
- Issue 类型
- 重构
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- java
- 领域
- backend, networking
调研方向
Start with protocol/src/main/protos/core/Discover.proto and identify the four legacy message definitions; keep Endpoint and BackupMessage unchanged. Read the Chinese and English protocol documents and the compatibility discussion in issue #6921 before deciding whether removal can proceed. If approved, regenerate protobuf sources from a clean state, compile, run the handshake and backup keepalive regression tests, and compare retained-message serialization against pre-change fixtures.
由索引模型根据 Issue 内容生成。
描述
Background
protocol/src/main/protos/core/Discover.proto still contains four legacy message definitions that are no longer referenced by java-tron’s runtime code: PingMessage, PongMessage, FindNeighbours, and Neighbours. These proto definitions are redundant leftovers from the libp2p split.
UDP discovery now uses the separate proto definitions in p2p/src/main/proto/Discover.proto (introduced in PR #6992).
Rationale
Remove unused definitions to reduce maintenance overhead and avoid confusion with the UDP discovery.
Specification
- Remove the four legacy messages from
protocol/src/main/protos/core/Discover.proto. - Preserve
Endpoint, referenced byHelloMessage.from, andBackupMessage, used by backup keepalive messages, with their existing fields and options. - Update the Chinese and English protocol documents to point to the real p2p discovery definitions.
Test Specification
- Regenerate protobuf sources from a clean state and compile the project.
- Run the related handshake and backup keepalive regression tests.
- Compare serialization against pre-change fixtures for
Endpoint,HelloMessage, andBackupMessage.
Scope of Impact
The cleanup is intended to preserve node network behavior and the wire encoding of retained messages. It removes generated types and changes the file descriptor, so downstream code referencing the removed types must migrate or retain a compatible protocol version. Projects using their own copies are unaffected unless they adopt the removal.
Before removal, resolve whether these generated types fall under the public API compatibility policy in #6921. If they do, deprecate them for at least one release cycle and schedule removal for a future major release.
- 主要语言
- Java
- 星标
- 4.2k
- 派生
- 1.8k
- 平均合并
- 3 天 21 小时
- 30 天内合并 PR
- 13
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
tronprotocol/java-tron 的其他 Issue
-
[Feature] Validate ECKey inputs and improve key handling可能已有人在做 @Federico2014 于 16 天前认领。 未关闭type:feature
难度 4/5 3-5 天 新手友好度 40/100
tronprotocol/java-tron#6994 · 2 条评论 ·
维护者通常 1 天内回复
-
type:feature
难度 5/5 一周以上 新手友好度 25/100
tronprotocol/java-tron#6989 · 2 条评论 ·
维护者通常 1 天内回复
-
Robustness fixes for multiple issues可能已有人在做 @xxo1shine 于 18 天前认领。 未关闭
难度 5/5 一周以上 新手友好度 35/100
tronprotocol/java-tron#6969 · 8 条评论 ·
维护者通常 1 天内回复
-
[Feature] decouple json-rpc filter processing from Manager可能已有人在做 @0xbigapple 于 17 天前认领。 未关闭type:feature
难度 5/5 一周以上 新手友好度 48/100
tronprotocol/java-tron#6963 · 8 条评论 ·
维护者通常 1 天内回复
-
[Feature] Remove unused SM2/SM3 crypto engine可能已有人在做 @Federico2014 于 15 天前认领。 未关闭type:feature
难度 5/5 一周以上 新手友好度 28/100
tronprotocol/java-tron#6959 · 3 条评论 ·
维护者通常 1 天内回复
查看 tronprotocol/java-tron 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
-
难度 2/5 1-3 小时 新手友好度 68/100
Netcracker/qubership-integration-platform#1046 ·
维护者通常 2 天内回复
-
`check_java_version()` fails when Java path contains spaces (Windows / Git Bash, `C:\Program Files`)未关闭
难度 2/5 1-3 小时 新手友好度 68/100
-
Fix Math.ceilDiv wrong result for exact positive divisions可能已有人在做 @pamod-madubashana 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 88/100
scala-native/scala-native#5094 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 2 天内回复