Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

[Feature] Remove unused discovery message definitions

Ouverte
  • Quelque chose ne va pas ?
#7,013 2 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
35/100
Type d'issue
Refactorisation
Clarté
Plutôt claire
Activité
Active
Stack technique
java
Domaine
backend, networking

Piste de recherche

Start with protocol/src/main/protos/core/Discover.proto and identify the four legacy message definitions; keep Endpoint and BackupMessage unchanged. Read the Chinese and English protocol documents and the compatibility discussion in issue #6921 before deciding whether removal can proceed. If approved, regenerate protobuf sources from a clean state, compile, run the handshake and backup keepalive regression tests, and compare retained-message serialization against pre-change fixtures.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

type:feature

Background

protocol/src/main/protos/core/Discover.proto still contains four legacy message definitions that are no longer referenced by java-tron’s runtime code: PingMessage, PongMessage, FindNeighbours, and Neighbours. These proto definitions are redundant leftovers from the libp2p split.

UDP discovery now uses the separate proto definitions in p2p/src/main/proto/Discover.proto (introduced in PR #6992).

Rationale

Remove unused definitions to reduce maintenance overhead and avoid confusion with the UDP discovery.

Specification

  • Remove the four legacy messages from protocol/src/main/protos/core/Discover.proto.
  • Preserve Endpoint, referenced by HelloMessage.from, and BackupMessage, used by backup keepalive messages, with their existing fields and options.
  • Update the Chinese and English protocol documents to point to the real p2p discovery definitions.

Test Specification

  • Regenerate protobuf sources from a clean state and compile the project.
  • Run the related handshake and backup keepalive regression tests.
  • Compare serialization against pre-change fixtures for Endpoint, HelloMessage, and BackupMessage.

Scope of Impact

The cleanup is intended to preserve node network behavior and the wire encoding of retained messages. It removes generated types and changes the file descriptor, so downstream code referencing the removed types must migrate or retain a compatible protocol version. Projects using their own copies are unaffected unless they adopt the removal.

Before removal, resolve whether these generated types fall under the public API compatibility policy in #6921. If they do, deprecate them for at least one release cycle and schedule removal for a future major release.

Langage dominant
Java
Étoiles
4.2k
Forks
1.8k
Merge moyen
3 j 21 h
PR mergées (30 j)
13

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de tronprotocol/java-tron

Toutes les issues de tronprotocol/java-tron

Issues similaires

Plus d'issues Java

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.