Trigger.dev CLI 4.8.3 — minimatch makeRe incompatibility and nested tar security findings

未关闭
#5,091 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
8/100
Issue 类型
重构
描述清晰度
需要澄清
活跃度
活跃
技术栈
nodejs, typescript

调研方向

The payload names dist/esm/build/externals.js, which imports makeRe from minimatch, and the dependency chain c12 → giget → [email protected]. The reporter's experiment failed and no fix is proposed, so the first step is a maintainer decision on the supported remediation path, not a code change. Done means maintainers have answered the five questions or a supported version has been identified.

由索引模型根据 Issue 内容生成。

描述

Provide environment information

Summary

We are requesting an officially supported remediation for security findings in the development dependency tree of [email protected].

The original CLI works with its declared minimatch dependency. The makeRe startup failure occurred only in an isolated, unsupported five-override compatibility experiment. That experiment FAILED and was NOT promoted.

Environment

  • OS: Windows 10.0.26300.0
  • Node.js: 24.14.0
  • npm: 11.9.0
  • Trigger.dev CLI: 4.8.3
  • Trigger.dev SDK: 4.8.3
  • npm lockfileVersion: 3

Original Security Audit

  • 9 affected-package entries
  • 1 critical, 6 high, 2 moderate
  • 16 unique GitHub Security Advisories
  • Production-only audit: zero findings
  • SDK-only audit: zero findings

Affected dependency paths:

[email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
│ └─ [email protected]
│ └─ [email protected]
└─ @trigger.dev/[email protected]
└─ @prisma/[email protected]
└─ [email protected]

Isolated Experiment

Five unsupported dependency overrides were tested in a disposable copy:

The CLI failed with:

trigger.dev/dist/esm/build/externals.js:
import { makeRe } from "minimatch";
SyntaxError: The requested module 'minimatch' does not provide an export named 'makeRe'

The distributed Trigger.dev CLI uses makeRe in its externals builder. minimatch 10.2.6 provides the API, but 11.0.1 does not.

The nested tar dependency remained invalidly resolved:

[email protected]
  [email protected]
    [email protected] invalid: "7.5.22"

The exact npm resolver cause has not been established.

Results

  • Original CLI startup: PASS
  • Experimental CLI startup: FAIL
  • Experimental audit: 4 affected-package entries, including 1 critical
  • Backend mock tests: 19 passed
  • Browser suites: 5 passed
  • Production build: PASS
  • Full experimental regression aggregate: incomplete

No experimental overrides were promoted.

Questions for Trigger.dev Maintainers

  1. Is there a supported CLI version or backport addressing minimatch GHSA-g3hv-75wg-m249 without breaking the makeRe API contract?
  2. What is the recommended remediation for c12 → giget → [email protected]?
  3. Are supported fixes available for the CLI's zod, esbuild and deepmerge-ts dependencies?
  4. Can you confirm the security status of bundled tar code in the @trigger.dev/build dependency chain?
  5. Is a separately pinned CLI workspace officially supported while keeping SDK 4.8.3?

We would appreciate a vendor-supported remediation path rather than unsupported major-version overrides.

No exploit has been demonstrated. The original dependency tree remains unchanged. Cloud is unconnected, MCP is disabled, and production booking is disabled.

Describe the bug

Trigger.dev CLI 4.8.3 has unresolved development dependency security advisories. The original CLI starts successfully with minimatch 10.2.6. However, an isolated, unsupported override to minimatch 11.0.1 causes CLI startup to fail because the CLI imports makeRe, which is no longer exported. A separate override targeting giget's nested tar dependency also resulted in an invalid dependency tree.

Expected: A vendor-supported, security-patched dependency combination that preserves CLI functionality.

Actual: The experimental overrides reduced audit findings from nine to four, but broke CLI startup and left one critical finding unresolved.

The experiment was not promoted. The original dependency tree remains unchanged. We are requesting official remediation guidance, not claiming the original CLI installation is broken.

Reproduction repo

No public reproduction repository is available yet. Minimal isolated reproduction steps are provided below; no private application source is required.

To reproduce

Environment: Windows NT 10.0.26300.0, Node.js 24.14.0, npm 11.9.0, [email protected], @trigger.dev/[email protected].

  1. Create an isolated disposable npm project with [email protected] as a development dependency and @trigger.dev/[email protected] as a runtime dependency.
  2. Install the dependencies and verify the original CLI version command succeeds.
  3. In a disposable copy, apply an npm override mapping [email protected]'s minimatch dependency to 11.0.1.
  4. Reinstall dependencies and verify minimatch 11.0.1 is resolved.
  5. Run the CLI version command.

Observed in our five-override experiment:

SyntaxError: The requested module 'minimatch' does not provide an export named 'makeRe'

The CLI imports makeRe from minimatch in dist/esm/build/externals.js. The original CLI uses minimatch 10.2.6, which supplies that API.

A separate experimental override attempted to replace [email protected]'s nested [email protected] with [email protected], but npm ls reported an invalid resolution. The exact npm resolver cause is unconfirmed.

Important: The isolated minimatch-only reproduction described above is proposed and has not been independently executed. The observed CLI failure occurred in the full five-override experiment. No overrides were promoted.

Suggested fix

No response

Additional information

No response

主要语言
TypeScript
星标
16.5k
派生
1.5k
平均合并
1 天 15 小时
30 天内合并 PR
17

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

triggerdotdev/trigger.dev 的其他 Issue

查看 triggerdotdev/trigger.dev 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。