Trigger.dev CLI 4.8.3 — minimatch makeRe incompatibility and nested tar security findings

Đang mở
  • Có gì không ổn?
#5,091 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
5/5
Thời gian dự kiến
Hơn một tuần
Mức phù hợp với người mới
8/100
Loại issue
Tái cấu trúc
Độ rõ ràng
Cần làm rõ
Mức độ hoạt động
Sôi nổi
Công nghệ
nodejs, typescript
Lĩnh vực
build-system, security

Hướng nghiên cứu

The payload names dist/esm/build/externals.js, which imports makeRe from minimatch, and the dependency chain c12 → giget → [email protected]. The reporter's experiment failed and no fix is proposed, so the first step is a maintainer decision on the supported remediation path, not a code change. Done means maintainers have answered the five questions or a supported version has been identified.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Provide environment information

Summary

We are requesting an officially supported remediation for security findings in the development dependency tree of [email protected].

The original CLI works with its declared minimatch dependency. The makeRe startup failure occurred only in an isolated, unsupported five-override compatibility experiment. That experiment FAILED and was NOT promoted.

Environment

  • OS: Windows 10.0.26300.0
  • Node.js: 24.14.0
  • npm: 11.9.0
  • Trigger.dev CLI: 4.8.3
  • Trigger.dev SDK: 4.8.3
  • npm lockfileVersion: 3

Original Security Audit

  • 9 affected-package entries
  • 1 critical, 6 high, 2 moderate
  • 16 unique GitHub Security Advisories
  • Production-only audit: zero findings
  • SDK-only audit: zero findings

Affected dependency paths:

[email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
│ └─ [email protected]
│ └─ [email protected]
└─ @trigger.dev/[email protected]
└─ @prisma/[email protected]
└─ [email protected]

Isolated Experiment

Five unsupported dependency overrides were tested in a disposable copy:

The CLI failed with:

trigger.dev/dist/esm/build/externals.js:
import { makeRe } from "minimatch";
SyntaxError: The requested module 'minimatch' does not provide an export named 'makeRe'

The distributed Trigger.dev CLI uses makeRe in its externals builder. minimatch 10.2.6 provides the API, but 11.0.1 does not.

The nested tar dependency remained invalidly resolved:

[email protected]
  [email protected]
    [email protected] invalid: "7.5.22"

The exact npm resolver cause has not been established.

Results

  • Original CLI startup: PASS
  • Experimental CLI startup: FAIL
  • Experimental audit: 4 affected-package entries, including 1 critical
  • Backend mock tests: 19 passed
  • Browser suites: 5 passed
  • Production build: PASS
  • Full experimental regression aggregate: incomplete

No experimental overrides were promoted.

Questions for Trigger.dev Maintainers

  1. Is there a supported CLI version or backport addressing minimatch GHSA-g3hv-75wg-m249 without breaking the makeRe API contract?
  2. What is the recommended remediation for c12 → giget → [email protected]?
  3. Are supported fixes available for the CLI's zod, esbuild and deepmerge-ts dependencies?
  4. Can you confirm the security status of bundled tar code in the @trigger.dev/build dependency chain?
  5. Is a separately pinned CLI workspace officially supported while keeping SDK 4.8.3?

We would appreciate a vendor-supported remediation path rather than unsupported major-version overrides.

No exploit has been demonstrated. The original dependency tree remains unchanged. Cloud is unconnected, MCP is disabled, and production booking is disabled.

Describe the bug

Trigger.dev CLI 4.8.3 has unresolved development dependency security advisories. The original CLI starts successfully with minimatch 10.2.6. However, an isolated, unsupported override to minimatch 11.0.1 causes CLI startup to fail because the CLI imports makeRe, which is no longer exported. A separate override targeting giget's nested tar dependency also resulted in an invalid dependency tree.

Expected: A vendor-supported, security-patched dependency combination that preserves CLI functionality.

Actual: The experimental overrides reduced audit findings from nine to four, but broke CLI startup and left one critical finding unresolved.

The experiment was not promoted. The original dependency tree remains unchanged. We are requesting official remediation guidance, not claiming the original CLI installation is broken.

Reproduction repo

No public reproduction repository is available yet. Minimal isolated reproduction steps are provided below; no private application source is required.

To reproduce

Environment: Windows NT 10.0.26300.0, Node.js 24.14.0, npm 11.9.0, [email protected], @trigger.dev/[email protected].

  1. Create an isolated disposable npm project with [email protected] as a development dependency and @trigger.dev/[email protected] as a runtime dependency.
  2. Install the dependencies and verify the original CLI version command succeeds.
  3. In a disposable copy, apply an npm override mapping [email protected]'s minimatch dependency to 11.0.1.
  4. Reinstall dependencies and verify minimatch 11.0.1 is resolved.
  5. Run the CLI version command.

Observed in our five-override experiment:

SyntaxError: The requested module 'minimatch' does not provide an export named 'makeRe'

The CLI imports makeRe from minimatch in dist/esm/build/externals.js. The original CLI uses minimatch 10.2.6, which supplies that API.

A separate experimental override attempted to replace [email protected]'s nested [email protected] with [email protected], but npm ls reported an invalid resolution. The exact npm resolver cause is unconfirmed.

Important: The isolated minimatch-only reproduction described above is proposed and has not been independently executed. The observed CLI failure occurred in the full five-override experiment. No overrides were promoted.

Suggested fix

No response

Additional information

No response

Ngôn ngữ chính
TypeScript
Star
16.5k
Fork
1.5k
Merge trung bình
1 ngày 15 giờ
Pull request đã merge (30 ngày)
17

Chuẩn bị môi trường

Dự án này không cung cấp dev container, Dockerfile hay hướng dẫn đóng góp, nên bạn cần tự thiết lập môi trường: hãy bắt đầu từ README và xem hướng dẫn đóng góp lần đầu của chúng tôi để biết các bước chung.

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của triggerdotdev/trigger.dev

Tất cả issue của triggerdotdev/trigger.dev

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.