Bug: API replay of a mollifier-buffered run drops region and gates (BufferedReplayInputSchema strips them)
维护者通常 1 天内回复
@Bhumit267 已经在做这个了。
开始于 2026年10月21日。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 72/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- redis, typescript
调研方向
Read apps/webapp/app/routes/api.v1.runs.$runParam.replay.ts and apps/webapp/app/v3/mollifier/readFallback.server.ts, then trace how ReplayTaskRunService uses region and gates. Check the existing replay tests for buffered runs and add coverage for preserving both fields through the API and dashboard paths. Done means buffered replay retains the stored region and named concurrency gates, matching replay from Postgres.
由索引模型根据 Issue 内容生成。
描述
Summary
Replaying a run that is still in the mollifier buffer through POST /api/v1/runs/:runParam/replay loses the run's stored region and gates. The buffered snapshot goes through BufferedReplayInputSchema, a plain z.object that declares neither field, so Zod strips both before the result is cast to TaskRun and handed to ReplayTaskRunService. Separately, SyntheticRun has no gates field at all, so the dashboard replay of a buffered run loses gates too.
Reproduction
- Setup: webapp with the mollifier buffer enabled, and a task triggered with named concurrency gates while the environment is over the mollifier threshold, so the run sits in the buffer (the snapshot is built by
#buildEngineTriggerInputand includesgates,workerQueueandregion). - Action:
POST /api/v1/runs/<friendlyId>/replaywhile the run is still buffered. - Trigger: the route reads the buffered entry with
findRunByIdWithMollifierFallback, runsBufferedReplayInputSchema.safeParse(buffered)and thenparsed.data as unknown as TaskRun. Every key the schema doesn't declare is dropped at that point.
Standalone repro of the parse step. The schema is copied verbatim from the route; the input is a SyntheticRun-shaped object as built by readFallback.server.ts:
import { z } from "zod";
const BufferedReplayInputSchema = z.object({
id: z.string(), friendlyId: z.string(), runtimeEnvironmentId: z.string(), taskIdentifier: z.string(),
payload: z.string(), payloadType: z.string(), queue: z.string(), isTest: z.boolean(),
traceId: z.string(), spanId: z.string(), engine: z.string(), runTags: z.array(z.string()),
concurrencyKey: z.string().nullable().optional(), workerQueue: z.string().nullable().optional(),
machinePreset: z.string().nullable().optional(), realtimeStreamsVersion: z.string().nullable().optional(),
seedMetadata: z.string().nullable().optional(), seedMetadataType: z.string().nullable().optional(),
});
const parsed = BufferedReplayInputSchema.parse({
id: "run_1", friendlyId: "run_1", runtimeEnvironmentId: "env_1", taskIdentifier: "t",
payload: "{}", payloadType: "application/json", queue: "task/t", isTest: false,
traceId: "a".repeat(32), spanId: "b".repeat(16), engine: "V2", runTags: [],
workerQueue: "us-east-1-base", region: "eu-central-1", gates: [{ queue: "g1" }],
});
console.log("region" in parsed, "gates" in parsed); // false false
I ran this with npx tsx from apps/webapp (zod 4.5.4).
Actual behavior
regionandgatesare missing from the object passed toReplayTaskRunService.call.- The replay service computes
overrideOptions.region || existingTaskRun.region || baseWorkerQueue(existingTaskRun.workerQueue), so it uses the worker-queue fallback instead of the stored region. - It passes
gates: undefined, so the replayed run is created without the original run's named concurrency gates. - Once the drainer has written the same run to Postgres, replaying it does keep
regionandgates. Whether a replay keeps them therefore depends on whether the run happened to still be buffered.
Expected behavior
A buffered-source replay should carry the same fields as a PG-source replay. The route comment calls the schema a "Manual sync point" covering the fields ReplayTaskRunService consumes, and the service reads region and gates, which the schema doesn't include. Zod strips them silently, and the safeParse + 404 guard doesn't catch it because they are optional.
Environment
- Version/commit:
main@ 93465d8549a735074d1ce7696bae3faebe577e8d - OS: Ubuntu (Linux), Node v24.21.0
- Relevant configuration: mollifier buffer enabled (run must still be buffered at replay time); the gates case needs a task/trigger with named concurrency gates
Evidence
- Schema without
region/gates: https://github.com/triggerdotdev/trigger.dev/blob/93465d8549a735074d1ce7696bae3faebe577e8d/apps/webapp/app/routes/api.v1.runs.%24runParam.replay.ts#L25-L50 - Parse + cast: https://github.com/triggerdotdev/trigger.dev/blob/93465d8549a735074d1ce7696bae3faebe577e8d/apps/webapp/app/routes/api.v1.runs.%24runParam.replay.ts#L102-L116
- Service reads
region: https://github.com/triggerdotdev/trigger.dev/blob/93465d8549a735074d1ce7696bae3faebe577e8d/apps/webapp/app/v3/services/replayTaskRun.server.ts#L107-L111 - Service reads
gates: https://github.com/triggerdotdev/trigger.dev/blob/93465d8549a735074d1ce7696bae3faebe577e8d/apps/webapp/app/v3/services/replayTaskRun.server.ts#L153-L155 - Buffered snapshot includes
gates,workerQueue,region: https://github.com/triggerdotdev/trigger.dev/blob/93465d8549a735074d1ce7696bae3faebe577e8d/apps/webapp/app/runEngine/services/triggerTask.server.ts#L981-L983 SyntheticRunexposesregionbut has nogates: https://github.com/triggerdotdev/trigger.dev/blob/93465d8549a735074d1ce7696bae3faebe577e8d/apps/webapp/app/v3/mollifier/readFallback.server.ts#L88 and https://github.com/triggerdotdev/trigger.dev/blob/93465d8549a735074d1ce7696bae3faebe577e8d/apps/webapp/app/v3/mollifier/readFallback.server.ts#L227- Dashboard path spreads
SyntheticRun(keepsregion, still nogates): https://github.com/triggerdotdev/trigger.dev/blob/93465d8549a735074d1ce7696bae3faebe577e8d/apps/webapp/app/v3/mollifier/syntheticReplayTaskRun.server.ts#L44
Additional context
Confirmed from code and the standalone parse repro:
- The API path drops
regionandgates. - Both buffered replay paths (API and dashboard) drop
gates, becauseSyntheticRunnever mapssnapshot.gates.
Not verified end to end: I did not run a buffered replay against a live webapp with Redis.
Hypothesis about region impact: a visible difference needs the fallback baseWorkerQueue(workerQueue) to differ from the stored region. At trigger time region comes from regionForQueue, which returns the worker group's region label rather than its master-queue name, so the two can differ. I haven't checked how the downstream region resolution treats a master-queue name.
Possible fix: add region and gates to BufferedReplayInputSchema and map snapshot.gates onto SyntheticRun. Alternatively, derive the schema from SyntheticRun so the two can't drift apart again.
Found with an anti-slop oxlint scan (no-chained-type-assertions on the as unknown as TaskRun cast), then checked by hand.
- 主要语言
- TypeScript
- 星标
- 16.5k
- 派生
- 1.5k
- 平均合并
- 1 天 15 小时
- 30 天内合并 PR
- 17
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
triggerdotdev/trigger.dev 的其他 Issue
-
bug: retry.fetch ignores the caller's abort signal and retries aborted requests可能重新可做 关联的 PR 已关闭且未合并。 未关闭
难度 2/5 1-3 小时 新手友好度 76/100
triggerdotdev/trigger.dev#5116 · 2 条评论 ·
维护者通常 1 天内回复
-
bug: Chat transport crashes on Safari < 17.4: AbortSignal.any is not a function可能重新可做 关联的 PR 已关闭且未合并。 未关闭
难度 2/5 1-3 小时 新手友好度 83/100
triggerdotdev/trigger.dev#5098 · 2 条评论 ·
维护者通常 1 天内回复
-
bug: Side menu items lose their active state on detail pages可能重新可做 关联的 PR 已关闭且未合并。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
triggerdotdev/trigger.dev#5088 ·
维护者通常 1 天内回复
-
bug: RBAC loader logs "plugin found but failed to load" when @triggerdotdev/plugins is simply not installed可能重新可做 @itsfaryal 于 17 天前认领,目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 82/100
triggerdotdev/trigger.dev#5083 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 83/100
triggerdotdev/trigger.dev#5072 · 1 条评论 ·
维护者通常 1 天内回复
查看 triggerdotdev/trigger.dev 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
bug platform-android
难度 2/5 1-3 小时 新手友好度 68/100
Termix-SSH/Mobile#146 · 1 条评论 ·
维护者通常 2 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 66/100
devswha/herdr-web-ui#3875 ·
-
难度 1/5 1 小时以内 新手友好度 88/100
-
area: runtime chore cli consistency dependencies developer-experience difficulty: easy discovery documentation enhancement good first issue help wanted hygiene json-output packaging priority: P3 tests version
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复