Bug: API replay of a mollifier-buffered run drops region and gates (BufferedReplayInputSchema strips them)
メンテナーはふだん 1 日以内に返信
@Bhumit267 がすでに取り組んでいます。
2026年10月21日 から。
評価
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 初心者へのやさしさ
- 72/100
- issue の種類
- バグ
- 明瞭さ
- 明確に書かれている
- 活発さ
- 活発
- 技術スタック
- redis, typescript
調査の方向性
Read apps/webapp/app/routes/api.v1.runs.$runParam.replay.ts and apps/webapp/app/v3/mollifier/readFallback.server.ts, then trace how ReplayTaskRunService uses region and gates. Check the existing replay tests for buffered runs and add coverage for preserving both fields through the API and dashboard paths. Done means buffered replay retains the stored region and named concurrency gates, matching replay from Postgres.
索引モデルが issue の本文から書いたものです。
説明
Summary
Replaying a run that is still in the mollifier buffer through POST /api/v1/runs/:runParam/replay loses the run's stored region and gates. The buffered snapshot goes through BufferedReplayInputSchema, a plain z.object that declares neither field, so Zod strips both before the result is cast to TaskRun and handed to ReplayTaskRunService. Separately, SyntheticRun has no gates field at all, so the dashboard replay of a buffered run loses gates too.
Reproduction
- Setup: webapp with the mollifier buffer enabled, and a task triggered with named concurrency gates while the environment is over the mollifier threshold, so the run sits in the buffer (the snapshot is built by
#buildEngineTriggerInputand includesgates,workerQueueandregion). - Action:
POST /api/v1/runs/<friendlyId>/replaywhile the run is still buffered. - Trigger: the route reads the buffered entry with
findRunByIdWithMollifierFallback, runsBufferedReplayInputSchema.safeParse(buffered)and thenparsed.data as unknown as TaskRun. Every key the schema doesn't declare is dropped at that point.
Standalone repro of the parse step. The schema is copied verbatim from the route; the input is a SyntheticRun-shaped object as built by readFallback.server.ts:
import { z } from "zod";
const BufferedReplayInputSchema = z.object({
id: z.string(), friendlyId: z.string(), runtimeEnvironmentId: z.string(), taskIdentifier: z.string(),
payload: z.string(), payloadType: z.string(), queue: z.string(), isTest: z.boolean(),
traceId: z.string(), spanId: z.string(), engine: z.string(), runTags: z.array(z.string()),
concurrencyKey: z.string().nullable().optional(), workerQueue: z.string().nullable().optional(),
machinePreset: z.string().nullable().optional(), realtimeStreamsVersion: z.string().nullable().optional(),
seedMetadata: z.string().nullable().optional(), seedMetadataType: z.string().nullable().optional(),
});
const parsed = BufferedReplayInputSchema.parse({
id: "run_1", friendlyId: "run_1", runtimeEnvironmentId: "env_1", taskIdentifier: "t",
payload: "{}", payloadType: "application/json", queue: "task/t", isTest: false,
traceId: "a".repeat(32), spanId: "b".repeat(16), engine: "V2", runTags: [],
workerQueue: "us-east-1-base", region: "eu-central-1", gates: [{ queue: "g1" }],
});
console.log("region" in parsed, "gates" in parsed); // false false
I ran this with npx tsx from apps/webapp (zod 4.5.4).
Actual behavior
regionandgatesare missing from the object passed toReplayTaskRunService.call.- The replay service computes
overrideOptions.region || existingTaskRun.region || baseWorkerQueue(existingTaskRun.workerQueue), so it uses the worker-queue fallback instead of the stored region. - It passes
gates: undefined, so the replayed run is created without the original run's named concurrency gates. - Once the drainer has written the same run to Postgres, replaying it does keep
regionandgates. Whether a replay keeps them therefore depends on whether the run happened to still be buffered.
Expected behavior
A buffered-source replay should carry the same fields as a PG-source replay. The route comment calls the schema a "Manual sync point" covering the fields ReplayTaskRunService consumes, and the service reads region and gates, which the schema doesn't include. Zod strips them silently, and the safeParse + 404 guard doesn't catch it because they are optional.
Environment
- Version/commit:
main@ 93465d8549a735074d1ce7696bae3faebe577e8d - OS: Ubuntu (Linux), Node v24.21.0
- Relevant configuration: mollifier buffer enabled (run must still be buffered at replay time); the gates case needs a task/trigger with named concurrency gates
Evidence
- Schema without
region/gates: https://github.com/triggerdotdev/trigger.dev/blob/93465d8549a735074d1ce7696bae3faebe577e8d/apps/webapp/app/routes/api.v1.runs.%24runParam.replay.ts#L25-L50 - Parse + cast: https://github.com/triggerdotdev/trigger.dev/blob/93465d8549a735074d1ce7696bae3faebe577e8d/apps/webapp/app/routes/api.v1.runs.%24runParam.replay.ts#L102-L116
- Service reads
region: https://github.com/triggerdotdev/trigger.dev/blob/93465d8549a735074d1ce7696bae3faebe577e8d/apps/webapp/app/v3/services/replayTaskRun.server.ts#L107-L111 - Service reads
gates: https://github.com/triggerdotdev/trigger.dev/blob/93465d8549a735074d1ce7696bae3faebe577e8d/apps/webapp/app/v3/services/replayTaskRun.server.ts#L153-L155 - Buffered snapshot includes
gates,workerQueue,region: https://github.com/triggerdotdev/trigger.dev/blob/93465d8549a735074d1ce7696bae3faebe577e8d/apps/webapp/app/runEngine/services/triggerTask.server.ts#L981-L983 SyntheticRunexposesregionbut has nogates: https://github.com/triggerdotdev/trigger.dev/blob/93465d8549a735074d1ce7696bae3faebe577e8d/apps/webapp/app/v3/mollifier/readFallback.server.ts#L88 and https://github.com/triggerdotdev/trigger.dev/blob/93465d8549a735074d1ce7696bae3faebe577e8d/apps/webapp/app/v3/mollifier/readFallback.server.ts#L227- Dashboard path spreads
SyntheticRun(keepsregion, still nogates): https://github.com/triggerdotdev/trigger.dev/blob/93465d8549a735074d1ce7696bae3faebe577e8d/apps/webapp/app/v3/mollifier/syntheticReplayTaskRun.server.ts#L44
Additional context
Confirmed from code and the standalone parse repro:
- The API path drops
regionandgates. - Both buffered replay paths (API and dashboard) drop
gates, becauseSyntheticRunnever mapssnapshot.gates.
Not verified end to end: I did not run a buffered replay against a live webapp with Redis.
Hypothesis about region impact: a visible difference needs the fallback baseWorkerQueue(workerQueue) to differ from the stored region. At trigger time region comes from regionForQueue, which returns the worker group's region label rather than its master-queue name, so the two can differ. I haven't checked how the downstream region resolution treats a master-queue name.
Possible fix: add region and gates to BufferedReplayInputSchema and map snapshot.gates onto SyntheticRun. Alternatively, derive the schema from SyntheticRun so the two can't drift apart again.
Found with an anti-slop oxlint scan (no-chained-type-assertions on the as unknown as TaskRun cast), then checked by hand.
- 主要言語
- TypeScript
- スター
- 16.5k
- フォーク
- 1.5k
- 平均マージ
- 1日 15時間
- マージ済み PR(30日)
- 17
環境構築
このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
triggerdotdev/trigger.dev のほかの issue
-
bug: retry.fetch ignores the caller's abort signal and retries aborted requests再び着手できるかも このイシューのプルリクエストはマージされずにクローズされました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
triggerdotdev/trigger.dev#5116 · コメント 2 件 ·
メンテナーはふだん 1 日以内に返信
-
bug: Chat transport crashes on Safari < 17.4: AbortSignal.any is not a function再び着手できるかも このイシューのプルリクエストはマージされずにクローズされました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 83/100
triggerdotdev/trigger.dev#5098 · コメント 2 件 ·
メンテナーはふだん 1 日以内に返信
-
bug: Side menu items lose their active state on detail pages再び着手できるかも このイシューのプルリクエストはマージされずにクローズされました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
triggerdotdev/trigger.dev#5088 ·
メンテナーはふだん 1 日以内に返信
-
bug: RBAC loader logs "plugin found but failed to load" when @triggerdotdev/plugins is simply not installed再び着手できるかも @itsfaryal が 17 日前に担当しましたが、オープン中のプルリクエストはありません。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
triggerdotdev/trigger.dev#5083 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 83/100
triggerdotdev/trigger.dev#5072 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
triggerdotdev/trigger.dev の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
メンテナーはふだん 1 日以内に返信
-
bug platform-android
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
Termix-SSH/Mobile#146 · コメント 1 件 ·
メンテナーはふだん 2 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 66/100
devswha/herdr-web-ui#3875 ·
-
難易度 1/5 1時間未満 初心者へのやさしさ 88/100
-
area: runtime chore cli consistency dependencies developer-experience difficulty: easy discovery documentation enhancement good first issue help wanted hygiene json-output packaging priority: P3 tests version
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信