🐛 Bug Report: MCP instrumentation crashes on error results with non-text content

未关闭
#4,569 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@notshriyansh 已经在做这个了。

开始于 2026年10月6日。

  • #4570 来自 @notshriyansh —— 未关闭

评估

难度
3/5
预计耗时
1-2 天
新手友好度
73/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
python
领域
observability

调研方向

Read _execute_and_handle_result() in the MCP instrumentation and inspect how it handles CallToolResult errors; also check InstrumentedStreamWriter.send() for the similar streamed-content assumption. Reproduce with a CallToolResult containing ImageContent, then run the relevant instrumentation tests. Done means non-text error content no longer raises an instrumentation exception and the span records error.type = tool_error.

由索引模型根据 Issue 内容生成。

描述

Which component is this bug for?

All Packages

📜 Description

opentelemetry-instrumentation-mcp assumes that the first content block in an MCP CallToolResult with isError=True is always a TextContent.

In _execute_and_handle_result(), the instrumentation currently does:

result.content[0].text

when handling an MCP tool error.

However, MCP CallToolResult.content is a list of ContentBlock values and can contain other valid content types such as ImageContent, AudioContent, ResourceLink, or EmbeddedResource.

As a result, a valid MCP error result containing a non-text content block causes the instrumentation itself to raise AttributeError.

For example, this is a valid CallToolResult:

CallToolResult(
    content=[
        ImageContent(
            type="image",
            data="aGVsbG8=",
            mimeType="image/png",
        )
    ],
    isError=True,
)

Passing this result through _execute_and_handle_result() currently raises:

AttributeError: 'ImageContent' object has no attribute 'text'

The span is consequently recorded with error.type = AttributeError, rather than the MCP tool error being represented as a tool_error.

I also found a similar content[0]["text"] assumption in InstrumentedStreamWriter.send() when handling streamed error results, although I have not yet verified whether the same failure is reachable through the streaming path.

👟 Reproduction steps

This can be reproduced without an MCP server, network access, or credentials using a protocol-valid CallToolResult in the instrumentation's result-handling path:

from mcp.types import CallToolResult, ImageContent

result = CallToolResult(
    content=[
        ImageContent(
            type="image",
            data="aGVsbG8=",
            mimeType="image/png",
        )
    ],
    isError=True,
)

# Pass `result` through the MCP instrumentation's
# _execute_and_handle_result() path.

The current implementation attempts to access:

result.content[0].text

and raises:

AttributeError: 'ImageContent' object has no attribute 'text'

The span produced by the instrumentation has:

error.type = AttributeError

instead of treating the MCP result as a tool-level error.

👍 Expected behavior

The instrumentation should handle valid MCP error results regardless of the concrete ContentBlock type, without raising an exception itself.

The tool result should still produce an ERROR span with:

error.type = tool_error

and the instrumentation should not assume that the first content block is TextContent.

👎 Actual Behavior with Screenshots

A valid error result containing a non-text content block causes the instrumentation to raise:

AttributeError: 'ImageContent' object has no attribute 'text'

and the resulting span records:

error.type = AttributeError

This means the instrumentation can mask the actual MCP tool error.

🤖 Python Version

3.12.6

📃 Provide any additional context for the Bug.

Environment:

opentelemetry-instrumentation-mcp: 0.62.4
mcp: 1.26.0
fastmcp: 2.14.3
Python: 3.12.6

mcp==1.26.0 defines CallToolResult.content as a list of MCP content block types rather than a list containing only TextContent.

I have reproduced the failure directly against the current instrumentation code.

There is also a similar content[0]["text"] assumption in the streaming response writer path, which may need to be handled separately.

👀 Have you spent some time to check if this bug has been raised before?
  • I checked and didn't find similar issue
Are you willing to submit PR?

Yes I am willing to submit a PR!

主要语言
Python
星标
7.5k
派生
1.2k
平均合并
1 天 23 小时
30 天内合并 PR
3

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

traceloop/openllmetry 的其他 Issue

查看 traceloop/openllmetry 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。