🐛 Bug Report: MCP instrumentation crashes on error results with non-text content
Los mantenedores suelen responder en 1 día
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 73/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- python
- Área
- observability
Línea de trabajo
Read _execute_and_handle_result() in the MCP instrumentation and inspect how it handles CallToolResult errors; also check InstrumentedStreamWriter.send() for the similar streamed-content assumption. Reproduce with a CallToolResult containing ImageContent, then run the relevant instrumentation tests. Done means non-text error content no longer raises an instrumentation exception and the span records error.type = tool_error.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Which component is this bug for?
All Packages
📜 Description
opentelemetry-instrumentation-mcp assumes that the first content block in an MCP CallToolResult with isError=True is always a TextContent.
In _execute_and_handle_result(), the instrumentation currently does:
result.content[0].text
when handling an MCP tool error.
However, MCP CallToolResult.content is a list of ContentBlock values and can contain other valid content types such as ImageContent, AudioContent, ResourceLink, or EmbeddedResource.
As a result, a valid MCP error result containing a non-text content block causes the instrumentation itself to raise AttributeError.
For example, this is a valid CallToolResult:
CallToolResult(
content=[
ImageContent(
type="image",
data="aGVsbG8=",
mimeType="image/png",
)
],
isError=True,
)
Passing this result through _execute_and_handle_result() currently raises:
AttributeError: 'ImageContent' object has no attribute 'text'
The span is consequently recorded with error.type = AttributeError, rather than the MCP tool error being represented as a tool_error.
I also found a similar content[0]["text"] assumption in InstrumentedStreamWriter.send() when handling streamed error results, although I have not yet verified whether the same failure is reachable through the streaming path.
👟 Reproduction steps
This can be reproduced without an MCP server, network access, or credentials using a protocol-valid CallToolResult in the instrumentation's result-handling path:
from mcp.types import CallToolResult, ImageContent
result = CallToolResult(
content=[
ImageContent(
type="image",
data="aGVsbG8=",
mimeType="image/png",
)
],
isError=True,
)
# Pass `result` through the MCP instrumentation's
# _execute_and_handle_result() path.
The current implementation attempts to access:
result.content[0].text
and raises:
AttributeError: 'ImageContent' object has no attribute 'text'
The span produced by the instrumentation has:
error.type = AttributeError
instead of treating the MCP result as a tool-level error.
👍 Expected behavior
The instrumentation should handle valid MCP error results regardless of the concrete ContentBlock type, without raising an exception itself.
The tool result should still produce an ERROR span with:
error.type = tool_error
and the instrumentation should not assume that the first content block is TextContent.
👎 Actual Behavior with Screenshots
A valid error result containing a non-text content block causes the instrumentation to raise:
AttributeError: 'ImageContent' object has no attribute 'text'
and the resulting span records:
error.type = AttributeError
This means the instrumentation can mask the actual MCP tool error.
🤖 Python Version
3.12.6
📃 Provide any additional context for the Bug.
Environment:
opentelemetry-instrumentation-mcp: 0.62.4
mcp: 1.26.0
fastmcp: 2.14.3
Python: 3.12.6
mcp==1.26.0 defines CallToolResult.content as a list of MCP content block types rather than a list containing only TextContent.
I have reproduced the failure directly against the current instrumentation code.
There is also a similar content[0]["text"] assumption in the streaming response writer path, which may need to be handled separately.
👀 Have you spent some time to check if this bug has been raised before?
- I checked and didn't find similar issue
Are you willing to submit PR?
Yes I am willing to submit a PR!
- Lenguaje dominante
- Python
- Estrellas
- 7.5k
- Forks
- 1.2k
- Merge medio
- 1 d 23 h
- PR fusionados (30 d)
- 3
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de traceloop/openllmetry
-
🐛 Bug Report: OpenAI Responses: with_raw_response.create() raises when the body can't be parsed, though the uninstrumented call returnsPosiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abiertobug python
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
traceloop/openllmetry#4717 ·
Los mantenedores suelen responder en 1 día
-
🐛 Bug Report: Incomplete cache token migration after #4243 breaks Bedrock and Groq instrumentationPosiblemente ocupada @Quantum-Enigma-dot la tomó hace 21 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
traceloop/openllmetry#4665 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
🐛 Bug Report: OpenAI instrumentation drops gen_ai.usage.reasoning_tokens on streamed chat completionsPosiblemente ocupada @jayfeng7 la tomó hace 23 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
traceloop/openllmetry#4660 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Bug Report: Failed dataset deletes still remove local rows and columnsPosiblemente ocupada @inchang-ing la tomó hace 32 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
traceloop/openllmetry#4630 ·
Los mantenedores suelen responder en 1 día
-
🐛 Bug Report: LiteLLM instrumentation does not record seed, stop, frequency_penalty, presence_penaltyPosiblemente ocupada @shantam77 la tomó hace 38 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
traceloop/openllmetry#4598 · 2 comentarios ·
Los mantenedores suelen responder en 1 día
Todos los issues de traceloop/openllmetry
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
mozilla-ai/cq#601 ·
Los mantenedores suelen responder en 1 día
-
Bump Python to 3.14 or 3.15Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Los mantenedores suelen responder en 1 día
-
intcomma returns exponential notation for large floatsPosiblemente ocupada @Omarinho12345 la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
python-humanize/humanize#521 ·
Los mantenedores suelen responder en 1 día
-
LUCJ pass manager raises NoEdgeBetweenNodes when an edge is bad for two two-qubit gatesPosiblemente ocupada @hat-im la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
Los mantenedores suelen responder en 1 día
-
opensubtitlescom: provider rejects pt-PT even though its own converter maps itPosiblemente ocupada @paulo-0308 la tomó hoy. Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
Diaoul/subliminal#1405 ·