[Bug]: updateUser saves part of an edit when a later field fails
还没有人认领这个 Issue。
评估
调研方向
Start by reading src/api/users.rs lines 213-254, where updateUser writes username, admin flag and permissions one by one and only checks the new password at the end. Then look at how other handlers in the repo open a transaction and do the admin-count check. Done means all validation happens before any write, and the writes plus admin check run in one transaction, with a test showing a rejected password leaves the rename unsaved.
由索引模型根据 Issue 内容生成。
描述
[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.
Version
0.40.0 (feat/desktop, 017a837b)
Area
Other
What happened?
updateUser writes the username, admin flag and permissions one by one, and only validates the new password at the end (src/api/users.rs:213–src/api/users.rs:254). A too-short password returns an error but the other changes are already saved. Nothing runs in a transaction, so two admins demoting each other at once can both pass the "at least one admin" check.
Steps to reproduce
Rename a user and set a 3-character password in the same edit: you get an error, but the rename went through.
Expected behavior
Either the whole edit applies or none of it does.
Suggested fix
Validate every field before writing anything, and do the writes (including the admin count check) in one transaction.
- 主要语言
- TypeScript
- 星标
- 4
- 派生
- 1
- 平均合并
- 4 小时 49 分钟
- 30 天内合并 PR
- 5
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
tinystream-dev/tinystream 的其他 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 82/100
tinystream-dev/tinystream#132 ·
-
bug
难度 2/5 1-3 小时 新手友好度 82/100
tinystream-dev/tinystream#131 ·
-
bug
难度 1/5 1 小时以内 新手友好度 88/100
tinystream-dev/tinystream#129 ·
-
bug
难度 2/5 1-3 小时 新手友好度 76/100
tinystream-dev/tinystream#128 ·
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
tinystream-dev/tinystream#124 ·
查看 tinystream-dev/tinystream 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 86/100
sandbox-quantum/switch#2163 ·
维护者通常 1 天内回复
-
automated issue report
难度 1/5 1 小时以内 新手友好度 78/100
维护者通常 1 天内回复
-
area/dashboard kind/bug QA/dev-automation
难度 1/5 1 小时以内 新手友好度 75/100
维护者通常 1 天内回复
-
bug pydanty:is-working
难度 2/5 1-3 小时 新手友好度 82/100
pydantic/pydantic-ai#13939 ·
维护者通常 1 天内回复
-
self-host
难度 2/5 1-3 小时 新手友好度 70/100
funmusicplace/mirlo#2625 ·
维护者通常 1 天内回复