[Bug]: updateUser saves part of an edit when a later field fails

未關閉
#112 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
半天
新手友好度
48/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
rust
領域
backend

研究方向

Start by reading src/api/users.rs lines 213-254, where updateUser writes username, admin flag and permissions one by one and only checks the new password at the end. Then look at how other handlers in the repo open a transaction and do the admin-count check. Done means all validation happens before any write, and the writes plus admin check run in one transaction, with a test showing a rejected password leaves the rename unsaved.

由索引模型根據 Issue 內容生成。

描述

bug

[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.

Version

0.40.0 (feat/desktop, 017a837b)

Area

Other

What happened?

updateUser writes the username, admin flag and permissions one by one, and only validates the new password at the end (src/api/users.rs:213–src/api/users.rs:254). A too-short password returns an error but the other changes are already saved. Nothing runs in a transaction, so two admins demoting each other at once can both pass the "at least one admin" check.

Steps to reproduce

Rename a user and set a 3-character password in the same edit: you get an error, but the rename went through.

Expected behavior

Either the whole edit applies or none of it does.

Suggested fix

Validate every field before writing anything, and do the writes (including the admin count check) in one transaction.

主要語言
TypeScript
星號
4
分支
1
平均合併
4 小時 49 分鐘
30 天內合併 PR
5

環境準備

  • 提供 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 沒有貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

tinystream-dev/tinystream 的其他 Issue

查看 tinystream-dev/tinystream 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。