refactor: modernize UserItem.CSVImport - use csv module for parsing
还没有人认领这个 Issue。
评估
调研方向
Start with UserItem.CSVImport, validate_file_for_import, _validate_import_line_or_throw, and create_user_from_line, then inspect test_password_with_comma_partially_masks. Done means parsing and username extraction use csv handling, and empty-input and too-many-column errors follow one convention.
由索引模型根据 Issue 内容生成。
描述
UserItem.CSVImport has some internal design smells worth cleaning up.
1. Use the csv module for parsing. Today the code does line.split(","), which misaligns whenever a field contains a comma - a password like "my,pa\$\$w0rd", a display name like "Smith, John". The column-1 mask added in #1829 only covers what lands in column 1; bytes that spill into column 2+ still leak (see test_password_with_comma_partially_masks). csv.reader also handles quoted values, CRLF, and BOM deliberately rather than coincidentally.
2. Consolidate two username extractions. validate_file_for_import uses line.partition(",")[0].strip(), while _validate_import_line_or_throw uses list(map(str.strip, line.split(",")))[USERNAME]. Same result today, but a maintenance hazard. A csv.reader migration collapses both.
3. Align error handling in create_user_from_line. It returns None for empty input but raises ValueError for too many columns. Pick one convention.
🤖 Generated with Claude Code
- 主要语言
- Python
- 星标
- 716
- 派生
- 446
- 平均合并
- 8 天 8 小时
- 30 天内合并 PR
- 2
贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
tableau/server-client-python 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 70/100
tableau/server-client-python#1865 ·
-
in-progress
难度 2/5 1-3 小时 新手友好度 78/100
tableau/server-client-python#1829 · 1 条评论 ·
-
enhancement gap needs investigation
难度 2/5 1-3 小时 新手友好度 68/100
tableau/server-client-python#1322 · 1 条评论 ·
-
[Type2] Allow Incremental Refresh type schedules to be added via `server.schedules.add_to_schedule` 未关闭help wanted Server-Side Enhancement ui-exists
难度 2/5 1-3 小时 新手友好度 68/100
tableau/server-client-python#1101 · 3 条评论 ·
-
enhancement good first issue
难度 2/5 1-3 小时 新手友好度 68/100
tableau/server-client-python#783 · 5 条评论 ·
查看 tableau/server-client-python 的全部 Issue
相似的 Issue
-
bug confirmed issue
难度 2/5 1-3 小时 新手友好度 75/100
open-webui/open-webui#30750 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
-
enhancement
难度 2/5 1-3 小时 新手友好度 75/100
OpenwaterHealth/openmotion-bloodflow-app#604 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
-
good first issue
难度 1/5 1 小时以内 新手友好度 90/100