Privileged ServiceAccounts without rackAwarness enabled
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 72/100
调研方向
Start with hdfs_clusterrolebinding_nodes_controller.rs, where HdfsCluster ServiceAccounts are added to hdfs-clusterrolebinding-nodes, and review the spec.clusterConfig.rackAwareness checks used around core_site.rs. Update the reflector to watch full HdfsCluster objects with DeserializeGuard so invalid clusters do not block reconciliation. The change is done when only rack-awareness-enabled clusters appear as subjects, while existing bindings and unrelated cluster reconciliation remain correct; run the repository's relevant Rust tests if present.
由索引模型根据 Issue 内容生成。
描述
Affected Stackable version
25.7.0, 25.11.0, 26.3.0 and 26.7.0
Affected Apache HDFS version
all
Current and expected behavior
Current
hdfs-operator maintains a single ClusterRoleBinding hdfs-clusterrolebinding-nodes to the ClusterRole hdfs-clusterrole-nodes, which grants cluster-wide get/list/watch on pods, nodes and endpoints (plus listeners and CRDs). It exists for the rack awareness topology provider.
The operator adds the ServiceAccount of every HdfsCluster as a subject, whether or not rackAwareness is set. The topology provider is only configured when rackAwareness is set (core_site.rs), so clusters without it get these rights without using them.
Expected
A HdfsCluster's ServiceAccount is only a subject of hdfs-clusterrolebinding-nodes when that cluster sets rackAwareness.
Fix
In hdfs_clusterrolebinding_nodes_controller.rs, only add clusters with spec.clusterConfig.rackAwareness set. The reflector currently watches PartialObjectMeta (no spec), so it needs to watch full objects, using DeserializeGuard so one broken HdfsCluster doesn't block the binding for all of them.
Out of scope: the ServiceAccount is shared by all roles, but only the NameNode runs the topology provider.
Possible solution
No response
Additional context
No response
Environment
No response
Would you like to work on fixing this bug?
No response
- 主要语言
- Rust
- 星标
- 53
- 派生
- 10
- 平均合并
- 21 小时 32 分钟
- 30 天内合并 PR
- 10
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
stackabletech/hdfs-operator 的其他 Issue
-
难度 3/5 1-2 天 新手友好度 61/100
stackabletech/hdfs-operator#853 ·
维护者通常 1 天内回复
-
Topology Provider permissions briefly dropped during reconciliation when the reflector watch resets未关闭type/bug
难度 4/5 3-5 天 新手友好度 42/100
stackabletech/hdfs-operator#774 ·
维护者通常 1 天内回复
-
type/bug
难度 3/5 1-2 天 新手友好度 58/100
stackabletech/hdfs-operator#773 ·
维护者通常 1 天内回复
-
type/internal-debt
难度 5/5 一周以上 新手友好度 15/100
stackabletech/hdfs-operator#769 ·
维护者通常 1 天内回复
-
type/bug
难度 3/5 1-2 天 新手友好度 52/100
stackabletech/hdfs-operator#763 ·
维护者通常 1 天内回复
查看 stackabletech/hdfs-operator 的全部 Issue
相似的 Issue
-
Unit tests use deprecated constant (part 2)可能已有人在做 @servo-highfive 今天认领。 未关闭E-less-complex
难度 1/5 1 小时以内 新手友好度 84/100
维护者通常 1 天内回复
-
bug good first issue help wanted linux macos testing
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复
-
area: app type: test
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
bug priority: medium
难度 2/5 1-3 小时 新手友好度 78/100
storytold/photocraft#12706 · 1 条评论 ·
维护者通常 1 天内回复
-
bug priority-low to-agent
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复