Skip the key and node maps on single-row list edits?
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 25/100
- Issue 类型
- 功能
- 描述清晰度
- 需要澄清
- 活跃度
- 活跃
- 技术栈
- javascript, typescript
- 领域
- frontend, performance
调研方向
The issue names reconcileArrays, mapArray, and flatten, but gives no file paths or test names. Read those implementations and the existing list reconciliation tests, then check the reported size gate and benchmark setup. Done means maintainers decide which optimizations, if any, merit a PR and resolve the duplicate-key and moved-node behavior questions.
由索引模型根据 Issue 内容生成。
描述
On 500-row keyed lists, moving one row takes about 100 µs, against about 25 µs to remove one, because reconcileArrays and mapArray each build a map that a two-pointer walk doesn't need. I have a prototype that skips them for end moves, swaps and order-keeping removals, plus a flatten fast path. Is any of it worth a PR?
Solid-only A/B on the Octane fork, 3 rounds on a machine that wasn't idle, so this needs a clean board run:
| Suite | Reconcile only | All three |
|---|---|---|
js-framework-reorder |
−9.3% | −15.6% |
js-framework |
−4.2% | −5.4% (swap −52%) |
uibench |
−2.3% | −7.9% (one-row moves −59%) |
Brotli on js-framework |
+65 B | +240 B |
The existing suites pass, but I haven't written new specs. All three changes fail the size gate, at about +850 B minified on app scenarios.
Questions:
- Which of these would justify a size exception, if any?
stageEndspairs duplicate keys by position, so row-local state can land on a different duplicate. Should it decline that case?- With the reconcile change, a node that user code moved out of the list can stay out where
nextpulls it back. Is that acceptable?
- 主要语言
- TypeScript
- 星标
- 36.2k
- 派生
- 1.1k
- 平均合并
- 9 小时
- 30 天内合并 PR
- 463
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
solidjs/solid 的其他 Issue
-
难度 4/5 3-5 天 新手友好度 54/100
维护者通常 1 天内回复
-
`<style>` and `<script>` children inside MathML are not escaped in SSR (and static DOM templates), allowing markup injection可能已有人在做 @santhiprakash 今天认领。 未关闭
难度 3/5 1-2 天 新手友好度 68/100
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 72/100
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 55/100
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 55/100
维护者通常 1 天内回复
相似的 Issue
-
The sample email preview's ResizeObserver is never disconnected and keeps raising errors after leaving Settings可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭bug
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
area:ui bug effort:S priority:P2
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
Typo in WSL project description on Projects page可能已有人在做 @akhil9tiet 今天认领。 未关闭
难度 1/5 1 小时以内 新手友好度 75/100
microsoft/opensource.microsoft.com#1066 · 1 条评论 ·
-
ArcGIS Maps SDK for JavaScript c-carousel calcite-design-tokens enhancement impact - p3 - not time sensitive needs triage
难度 2/5 1-3 小时 新手友好度 68/100
Esri/calcite-design-system#15565 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 68/100
linkwarden/linkwarden#1891 ·
维护者通常 1 天内回复