updates to a Input's disabled property causes the value property to reset

未关闭
  • 哪里不对？
#4,702 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
72/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
javascript, typescript
领域
frontend

调研方向

Start by reproducing the behavior in the linked Solid playground, comparing the four input cases when you edit their values and toggle disabled. Then trace how Solid updates input properties in its DOM rendering code and find the relevant tests. Done means toggling disabled does not reset an edited value when value is reactive, with the other cases still behaving as expected.

由索引模型根据 Issue 内容生成。

描述

When both the disabled and value property of an input are signals, changes to the disabled property causes the value to reset to its initial value even after being modified.

Is this expected behavior?

Below is both code and a playground link. Just change the values in the four boxes and then click "CLICK ME".

https://playground.solidjs.com/MattLysinger/6fabf761-9664-462b-a96e-2e5f82c3b3f3

import { render } from "@solidjs/web";
import { createSignal } from "solid-js";

function Counter() {
  let ref1!: HTMLInputElement;
  let ref2!: HTMLInputElement;
  const [disabled, setDisabled] = createSignal(false);
  const [value, setValue] = createSignal(11);

  return (
    <>
      <button
        type="button"
        onClick={() => {
          setDisabled((x) => !x);
          ref1.disabled = !ref1.disabled;
          ref2.disabled = !ref2.disabled;
        }}
      >
        CLICK ME
      </button>
      
      <p>1. disabled & value are both signals and the disabled signal is toggled</p>
      <input disabled={disabled()} type="number" value={value()} />
      
      <p>2. disabled is a signal and value is a number and the disabled signal is toggled</p>
      <input disabled={disabled()} type="number" value={11} />
      
      <p>3. value is a signal and the disabled property is directly toggled</p>
      <input ref={ref1} type="number" value={value()} />
      
      <p>4. value is a number and the disabled signal is directly toggled</p>
      <input ref={ref2} type="number" value={11} />
    </>
  );
}

render(() => <Counter />, document.getElementById("app")!);

Originally posted by @MattLysinger in https://github.com/solidjs/solid/discussions/4496

主要语言
TypeScript
星标
36.2k
派生
1.1k
平均合并
9 小时
30 天内合并 PR
463

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

solidjs/solid 的其他 Issue

查看 solidjs/solid 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。