Filter the Analysis Catalog by lexicon link

未关闭
  • 哪里不对？
#564 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
38/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
typescript
领域
frontend, testing

调研方向

Start with src/utils/analysis-query.ts and its analysis-query.test.ts tests, then inspect the catalog panel’s existing filter controls and reconcileFilters. First resolve the listed design choices: what counts as linked, when to show the filter, whether refs need to match the active lexicon, and whether to use one or two toggles. Done means the chosen behavior is available in the panel and covered for each choice, including rows without morphemes and morphemes with an empty form; the issue also depends on #540.

由索引模型根据 Issue 内容生成。

描述

Part of #46. #228 lists it as a likely follow-up and leaves it out of its own scope.

Lets a user narrow the Analysis Catalog to rows that are, or aren't, linked to a lexicon sense. For example, they can find what still needs linking, or check what an import brought in.

Scope

  • A filter on CatalogFilters, applied in passesFilters (src/utils/analysis-query.ts) alongside the existing toggle filters, and added to TOGGLE_FILTER_KEYS if it is a toggle.
  • A control for it in the catalog panel, next to the other filters.
  • Tests in analysis-query.test.ts for each choice, including rows with no morphemes and morphemes with an empty form.

To decide

  1. What counts as linked.
    • The token's glossSenseRef only: simple, and matches what the row header shows first. It misses rows linked only at the morpheme level.
    • Any morpheme's senseRef: finds morpheme-level work. It misses whole-word and idiom links, and a token with no morphemes can never match it.
    • Either level: a single meaning of "linked". But "unlinked" then means "no ref anywhere", so a partly linked breakdown counts as linked.
    • Separate filters per level: precise, but adds two controls where the others add one.
    • "Fully linked": the token plus every morpheme with a non-empty form. It matches what "done" means, but it's harder to explain and test.
  2. When the filter is offered.
    • Only while a lexicon is linked: matches the original ask. But #228 and #540 show a ref an analysis carries even in tier 0 or when the provider can't search, so a tier-0 user with imported refs could see links but not filter by them. reconcileFilters would also have to drop an active selection when the lexicon is unlinked, the same way it drops a withdrawn facet.
    • Always: consistent with how refs are displayed, and needs no lexicon state in the query. In tier 0 with no refs at all, though, it's a control that always returns everything or nothing.
    • Whenever any row carries a ref: offered when it can matter, with no lexicon state needed. It is derived like a facet, so the control can disappear while it is active, which reconcileFilters has to handle.
  3. Ref presence or resolution.
    • Presence: pure and synchronous like every other catalog filter, with no lexicon calls. A dangling ref (entry deleted, provider offline) still counts as linked.
    • Resolvable refs: "linked" means something the user can open. But this needs every row resolved, which conflicts with resolving only on-screen rows (#227, #540), and results change when the provider goes offline.
  4. Refs from another provider (#225).
    • Any ref counts: no knowledge of the active lexicon needed.
    • Only refs matching the active lexicon's authority and project: matches what the user can act on. The query then depends on which lexicon is active, and a row linked to an old lexicon counts as unlinked.
  5. Shape.
    • One tri-state toggle, like morphemes: 'has' | 'lacks'. It matches the existing pattern, but only fits if question 1 lands on a single level.
    • Two independent toggles: this suits per-level filtering, though it uses more panel space.

Not here

  • Filtering by disagreement between the typed gloss and the resolved sense gloss. It needs every row resolved (see question 3).
  • Filtering by linked entry or sense, which is a value facet and would need resolution.
  • Linking and unlinking: #542.

Depends on

  • #540, so a kept row shows why it was kept.

Notes

Nothing here writes, so it doesn't wait for the data layer plan (#417). getCatalogRows in #456 takes the same CatalogFilters; whichever lands second carries the filter.

主要语言
TypeScript
星标
2
派生
0
平均合并
1 天 9 小时
30 天内合并 PR
78

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

sillsdev/interlinearizer-extension 的其他 Issue

查看 sillsdev/interlinearizer-extension 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。