Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Shared sparse one-hot (indicator) helper for squidpy and scanpy

未关闭
#224 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
72/100
Issue 类型
重构
描述清晰度
描述清楚
活跃度
活跃
技术栈
numpy, python
领域
tooling

调研方向

Start with scanpy/get/_aggregated.py and squidpy/gr/_nhood.py, then review the proposed fast_array_utils.conv entry point and its sparse extra. Confirm the shared helper preserves missing labels, unused categories, mask handling, float64 output, and the stated matrix layouts; done means both callers use it without changing their current behavior.

由索引模型根据 Issue 内容生成。

描述

prettified with ai, basically saying we have two different functions we can unify here. low prio but good to document.

scanpy (sparse_indicator in scanpy/get/_aggregated.py) and squidpy (_onehot in squidpy/gr/_nhood.py) each keep a private helper that turns category codes into a sparse float64 indicator matrix, with a missing label (-1) giving no entry. They differ only in interface: scanpy takes a pd.Categorical and returns (n_categories, n_obs) as a coo_array with an optional mask, while squidpy takes a pd.Series and returns a (n_obs, n_categories) csr_matrix.

Proposal for fast_array_utils.conv (needs the sparse extra; takes codes since fast-array-utils doesn't depend on pandas):

def sparse_indicator(
    codes: NDArray[np.integer], n_categories: int, *, mask: NDArray[np.bool] | None = None
) -> coo_array:
    keep = codes >= 0 if mask is None else (codes >= 0) & mask
    obs = np.flatnonzero(keep)
    return coo_array((np.ones(obs.size), (obs, codes[keep])), shape=(codes.size, n_categories))
  • (n_obs, n_categories), the usual one-hot layout; scanpy takes .T (about 3 ms at 5M observations).
  • float64, as both callers use today.
  • Same cost as both copies today: squidpy converts the result to CSR, as it does now.

checked with missing labels, unused categories and mask.

as discussed in squidpy/#1285

主要语言
Python
星标
15
派生
5
平均合并
10 小时 24 分钟
30 天内合并 PR
12

环境准备

我们还没有检查这个项目的环境配置文件。先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

scverse/fast-array-utils 的其他 Issue

查看 scverse/fast-array-utils 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。