Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

LUFactorized Implemented?

未关闭
  • 哪里不对？
#314 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
25/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
rust
领域
data

调研方向

Start with the LUFactorized::factorize_into and solve_inplace implementations shown in the issue, then trace the A::lu and A::solve entry points. Confirm whether the matrix passed to A::lu is mutated into factors and whether the stored ipiv is used; done when the behavior is explained or corrected with a regression test.

由索引模型根据 Issue 内容生成。

描述

I was having a look at the code behind LUFactorized and it appears that there is no LU factorization done at all. For example, the factorize_into source is

fn factorize_into(mut self) -> Result<LUFactorized<S>> {
    let ipiv = A::lu(self.layout()?, self.as_allocated_mut()?)?;
    Ok(LUFactorized { a: self, ipiv })
}

where self here is the original matrix. While it is fine to be storing the original matrix A (perhaps the LU decomposition is lazily evaluated), the solve_inplace code indicates that this is actually not the case at all. Instead it just uses the standard solve function without actually doing any LU decomposition at any point.

fn solve_inplace<'a, Sb>(
    &self,
    rhs: &'a mut ArrayBase<Sb, Ix1>,
) -> Result<&'a mut ArrayBase<Sb, Ix1>>
where
    Sb: DataMut<Elem = A>,
{
    assert_eq!(
        rhs.len(),
        self.a.len_of(Axis(1)),
        "The length of `rhs` must be compatible with the shape of the factored matrix.",
    );
    A::solve(
        self.a.square_layout()?,
        Transpose::No,
        self.a.as_allocated()?,
        &self.ipiv,
        rhs.as_slice_mut().unwrap(),
    )?;
    Ok(rhs)
}

Am I missing something? Or is this a temporary implementation until an LU factorization can be properly implemented?

主要语言
Rust
星标
452
派生
95
30 天内没有已合并 PR

环境准备

我们还没有检查这个项目的环境配置文件。先看它的 README，通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

rust-ndarray/ndarray-linalg 的其他 Issue

查看 rust-ndarray/ndarray-linalg 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。