bug: install-stats by-release table credits smoke installs to the newest-published release, not the one installed

已关闭
  • 哪里不对？
#1,622 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

已经有一个关联 PR 被合并了。

  • #1623 来自 @Alan-Cha —— 已合并

评估

难度
3/5
预计耗时
半天
新手友好度
42/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
go, javascript, shell
领域
devtools, documentation

调研方向

Start in the install-stats page code that defines renderReleases, byPublication and ciByTag, and check how compareRelease is used there. Compare with scripts/release_smoke_test_linux.sh, which picks the highest stable release. The fix assigns each smoke run to the highest stable release published at or before the run's created_at. Done when the by-release table credits v0.8.1 for the Oct 4 to Oct 14 runs, with the tag-push residuals left documented.

由索引模型根据 Issue 内容生成。

描述

bug

Problem

The by-release table on docs/install-stats/ subtracts each release's smoke-test CI installs from its Linux column. It assigns each smoke run to whichever release was published most recently when the run started (byPublication / ciByTag in renderReleases), pre-releases included.

The smoke test installs something else. A job's fresh install is the highest-versioned stable release: gh release list --exclude-pre-releases, then sort -V | tail -1 (scripts/release_smoke_test_linux.sh). The script has excluded pre-releases since it was added in d0be885c.

The two rules disagree whenever the most recently published release isn't the highest stable version:

  • A pre-release is newest. This happened from Oct 4 to Oct 14, while v0.9.0-rc.1 through rc.4 were published. Every smoke run in those windows installed v0.8.1. I confirmed this from one run log per window: each says Fresh install: v0.8.1. The page credited those runs to the rcs instead.
  • A backport is newest. For example, a v0.8.2 published after v0.9.4. The page would credit it with runs that installed v0.9.4. This hasn't happened yet.

Effect on today's page

Release Linux CI the page subtracts CI by the smoke test's rule
v0.8.1 93 8 (shows 85 people) 80 (13 people)
v0.9.0-rc.1 to rc.4 1 to 9 each 4, 25, 39, 4 (rows show ~0) none from main pushes
v0.9.0 and later unchanged unchanged

So about 72 CI installs are attributed to the wrong releases. The daily table isn't affected, because it subtracts the CI total whichever release was installed.

The page recomputes everything from data.json on each load, so fixing the rule also corrects the existing history. Nothing needs re-collecting.

Fix

Assign each run to the highest-versioned stable release published at or before the run started, using the page's existing compareRelease. That is the smoke script's own rule, applied to data data.json already has (prerelease, published_at and each run's created_at).

Known residuals

  • Tag-push runs. A run triggered by a stable tag push installs the stable version below that tag, but this rule picks the tag itself. That puts 1 install on v0.9.0 and 2 on v0.9.1 into the wrong row so far. Fixing it needs the collector to record which ref triggered each run; today the smoke run's own head_branch is main even for tag pushes.
  • Contradicting comments. The collector's header says a tag push makes the people figure run "1-2 low per job"; the page says "1-2 high". The page is right: a tag-push job also installs the tag itself, which the page doesn't subtract. The "1-2" estimate also predates the cpex steps added in #1431, which install the tag several more times per job.

Found during the review of #1457.

主要语言
Go
星标
23
派生
44
平均合并
16 小时 8 分钟
30 天内合并 PR
234

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

rossoctl/cortex 的其他 Issue

查看 rossoctl/cortex 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。