chore: Remove the decline_responses_websockets translation after a deprecation release
维护者通常 1 天内回复
@Alan-Cha 已经在做这个了。
开始于 2026年11月3日。
评估
调研方向
First confirm that a release has shipped the warning and that the project is ready for a breaking change. Then inspect core/config/config.go and core/config/validate.go, and review the history of #1467 for the earlier refusal. Update TestLoad_DeprecatedDeclineKeyStillApplies into a refusal test and remove the old-key references from the three named docs; done means the old key is refused with a message naming its replacement mode and the release notes mark the change as breaking.
由索引模型根据 Issue 内容生成。
描述
What
v0.9.4 shipped listener.decline_responses_websockets, a boolean. #1467 replaces it with listener.responses_websockets: parse | decline | forward. To keep v0.9.4 configs working, #1467 still reads the old key when the new one is unset (true → decline, false → forward), logs a WARN naming the new key, and refuses a config that sets both.
This issue tracks removing that translation.
When
Not before both of these:
- At least one release has shipped the warning. A user who set the old key should have had a release that told them to change it before one that refuses it.
- A release the project is willing to label a breaking change. Before 1.0, semver allows a breaking change in any release, and this repo has done it: #1429 shipped in v0.9.2, a patch release, listed under "Breaking changes" in its notes. So this does not have to wait for 1.0, but it needs a deliberate release-notes entry, not a silent removal.
What removal means
Do not delete the field outright. If the field were simply deleted, the YAML would ignore the key, and a config that set decline_responses_websockets: false would quietly get the default, parse, with no word said. Replace the translation with a startup refusal that names the mode the old value maps to. That refusal is what #1467 did before v0.9.4 shipped the key, and it is in that PR's history.
core/config/config.go:DeclineResponsesWebSocketsand the fallback inResponsesWebSocketsMode.core/config/validate.go: the WARN and the both-set refusal become a single refusal.TestLoad_DeprecatedDeclineKeyStillAppliesbecomes a refusal test.- Docs:
docs/agents/codex.md,docs/framework-architecture.mdandCLAUDE.mddescribe the old key; drop those lines.
PR title prefix: Breaking change:, so the release notes say so.
- 主要语言
- Go
- 星标
- 23
- 派生
- 44
- 平均合并
- 16 小时 32 分钟
- 30 天内合并 PR
- 227
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
rossoctl/cortex 的其他 Issue
-
UI shows costs for all sessions even when drilled into a session可能已有人在做 @esnible 于 22 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 70/100
rossoctl/cortex#1116 · 2 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
-
Docs: Fix stale claims in CLAUDE.md and remove duplicated text可能已有人在做 @huang195 今天认领。 未关闭
rossoctl/cortex#1663 · 已指派 1 人 ·
维护者通常 1 天内回复
-
Fix: Stop the live and draining pipelines on shutdown, not the boot ones可能已有人在做 @evaline-ju 今天认领。 未关闭bug
rossoctl/cortex#1662 · 已指派 1 人 ·
维护者通常 1 天内回复
-
feedback laptop
难度 5/5 一周以上 新手友好度 28/100
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 60/100
维护者通常 1 天内回复
相似的 Issue
-
Logging into a locally started instance clears its container reference, causing stop to do nothing未关闭
难度 2/5 1-3 小时 新手友好度 79/100
microcks/microcks-cli#620 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 77/100
teradata-labs/loom#574 ·
维护者通常 1 天内回复
-
cli: name the CRID when saved link limits fail after publish; soften plain-republish mint warning未关闭enhancement pr-polish-followup priority: low
难度 2/5 1-3 小时 新手友好度 74/100
layervai/qurl-integrations#1994 ·
维护者通常 1 天内回复
-
bug needs-acceptance wg/router-models-inference-runtime
难度 2/5 1-3 小时 新手友好度 72/100
vllm-project/semantic-router#5891 ·
维护者通常 1 天内回复
-
bug needs triage
难度 2/5 1-3 小时 新手友好度 74/100
维护者通常 1 天内回复