Treat loosening a Point or polygon field contract as a compatible change

未关闭
#2,646 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
56/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
postgresql, rust
领域
backend, database

调研方向

Start with the widening rules in contract.rs and the geometry change classification in package.rs, then read covers_are_metadata_only in migration_plan.rs. Compare the existing Point precision behavior with the polygon case in tests/postgres_spatial_migration.rs. Done means loosening maximumPositions, precision, or bbox regenerates the CHECK constraint and PostGIS projection without requiring a SQL step, backup, or rehearsal, while tightening still requires a reviewed migration.

由索引模型根据 Issue 内容生成。

描述

area:breg enhancement

Changing a crs84-point or crs84-polygon field's contract is always treated as a destructive field type change, even when the change only loosens it. Raising maximumPositions (say from 100 to 500), raising precision, or widening or removing bbox cannot invalidate any retained value, yet the author has to write a reviewed migration with at least one SQL step, bind a backup and run a rehearsal.

Where
  • package.rs reports any geometry contract change as FieldTypeChanged.
  • FieldTypeChanged is not metadata-only (covers_are_metadata_only in migration_plan.rs), so a migration descriptor with no steps is refused.
  • The widening rules in contract.rs cover other field kinds but not Point or polygon contracts.
  • The polygon migration test needs a no-op rewrite step to change a contract (tests/postgres_spatial_migration.rs).

Point precision changes already behave this way, so #2644 is consistent with existing behaviour; this issue covers both.

Proposal

Classify loosening of a Point or polygon contract (higher maximumPositions, higher precision, wider or removed bbox) as a compatible change: the compiler regenerates the CHECK constraint and the generated PostGIS projection, with no SQL step, backup or rehearsal required. Tightening keeps the reviewed migration path, which already refuses retained values that violate the candidate contract before activation.

Until then, products/breg/SPATIAL-QUERIES.md should say what a contract change costs.

主要语言
Rust
星标
2
派生
0
平均合并
9 小时 48 分钟
30 天内合并 PR
151

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

registrystack/registry-stack 的其他 Issue

查看 registrystack/registry-stack 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。