Treat loosening a Point or polygon field contract as a compatible change

Aperta
#2,646 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
56/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
postgresql, rust
Ambito
backend, database

Direzione di ricerca

Start with the widening rules in contract.rs and the geometry change classification in package.rs, then read covers_are_metadata_only in migration_plan.rs. Compare the existing Point precision behavior with the polygon case in tests/postgres_spatial_migration.rs. Done means loosening maximumPositions, precision, or bbox regenerates the CHECK constraint and PostGIS projection without requiring a SQL step, backup, or rehearsal, while tightening still requires a reviewed migration.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:breg enhancement

Changing a crs84-point or crs84-polygon field's contract is always treated as a destructive field type change, even when the change only loosens it. Raising maximumPositions (say from 100 to 500), raising precision, or widening or removing bbox cannot invalidate any retained value, yet the author has to write a reviewed migration with at least one SQL step, bind a backup and run a rehearsal.

Where
  • package.rs reports any geometry contract change as FieldTypeChanged.
  • FieldTypeChanged is not metadata-only (covers_are_metadata_only in migration_plan.rs), so a migration descriptor with no steps is refused.
  • The widening rules in contract.rs cover other field kinds but not Point or polygon contracts.
  • The polygon migration test needs a no-op rewrite step to change a contract (tests/postgres_spatial_migration.rs).

Point precision changes already behave this way, so #2644 is consistent with existing behaviour; this issue covers both.

Proposal

Classify loosening of a Point or polygon contract (higher maximumPositions, higher precision, wider or removed bbox) as a compatible change: the compiler regenerates the CHECK constraint and the generated PostGIS projection, with no SQL step, backup or rehearsal required. Tightening keeps the reviewed migration path, which already refuses retained values that violate the candidate contract before activation.

Until then, products/breg/SPATIAL-QUERIES.md should say what a contract change costs.

Lingua principale
Rust
Stelle
2
Fork
0
Merge medio
9h 48m
PR unite (30g)
151

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di registrystack/registry-stack

Tutte le issue di registrystack/registry-stack

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.