Operators do not honour the Rx observable contract for terminal events

未关闭
  • 哪里不对？
#1,142 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
冷清
技术栈
csharp
领域
backend

调研方向

The issue describes a harness covering 476 observable-taking extension methods, but does not name its files or the two child issues containing the findings. Start by locating those child issues and the harness, then inspect the grouped operator implementations and their overloads. Verify completion and error behavior for every affected overload; the Switch cases are already handled by #1137 and #1139.

由索引模型根据 Issue 内容生成。

描述

Switch turned out to be dropping OnCompleted and mishandling OnError (#1136, #1138). That raised an obvious question: how many other operators do the same thing?

I wrote a harness that drives every operator overload with a source that completes or errors, and records what the operator actually emits. It covered 476 of the 499 extension methods that take an IObservable. The remainder do not return an observable, so there is nothing to assert.

106 overloads across 33 operator names either never deliver OnCompleted, or get the error path wrong by throwing out of Subscribe, converting the error to a completion, or dropping it entirely.

The findings are split by collection type in the two child issues. Several of the entries are the same bug reached by different names, so both lists are grouped by the implementation the overloads share rather than by public API name.

Worth noting for anyone picking this up: overloads of the same operator often do not share behaviour. Sort(comparer) completes correctly while Sort(observableComparer) and Sort(comparer, resorter) do not. Fixes need checking against every overload, not one representative.

The Switch entries in both lists are already handled by #1137 and #1139 and are only there for completeness.

主要语言
C#
星标
1.9k
派生
194
平均合并
12 分钟
30 天内合并 PR
1

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

reactivemarbles/DynamicData 的其他 Issue

查看 reactivemarbles/DynamicData 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。